🎉 New Source: Aha [low-code cdk] #18893

bala-ceg · 2022-11-03T06:48:33Z

What

Aha Integration: https://www.aha.io/api/

How

Added the end points of features,releases,goals,users and ideas

🚨 User Impact 🚨

No Impact. New Feature

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

marcosmarxm · 2022-11-04T01:17:44Z

Hello @bala-ceg, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

marcosmarxm · 2022-11-04T08:57:08Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

bala-ceg · 2022-11-07T03:26:10Z

Thanks @marcosmarxm for taking time to review this. DM'ed you on slack with test credentials and to the best of my knowledge I think I have all checklist items fulfilled

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
[x ] Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

marcosmarxm

Some comments please check them.

airbyte-integrations/connectors/source-aha/source_aha/schemas/TODO.md

airbyte-integrations/connectors/source-aha/source_aha/spec.yaml

airbyte-integrations/connectors/source-aha/source_aha/aha.yaml

bala-ceg · 2022-11-09T06:05:59Z

@marcosmarxm I addressed the review comments. Can you please review them?

marcosmarxm

The paginator is not used yet.

airbyte-integrations/connectors/source-aha/source_aha/aha.yaml

marcosmarxm · 2022-11-14T22:39:08Z

/test connector=connectors/source-aha

🕑 connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/3465751776
❌ connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/3465751776
🐛 https://gradle.com/s/kriorkzlxwzbm

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError:  Rec...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
=================== 1 failed, 23 passed, 3 skipped in 45.88s ===================

bala-ceg · 2022-11-15T00:50:37Z

/test connector=connectors/source-aha

🕑 connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/3465751776
❌ connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/3465751776
🐛 https://gradle.com/s/kriorkzlxwzbm

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError:  Rec...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
=================== 1 failed, 23 passed, 3 skipped in 45.88s ===================

@marcosmarxm in my local setup all tests are passing, can you please help me in fixing the test failures

marcosmarxm · 2022-11-15T01:45:02Z

/test connector=connectors/source-aha

🕑 connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/3466719200
✅ connectors/source-aha https://github.com/airbytehq/airbyte/actions/runs/3466719200
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:88: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:358: The previous connector image could not be retrieved.
======================== 26 passed, 3 skipped in 48.89s ========================

marcosmarxm · 2022-11-15T02:23:48Z

/publish connector=connectors/source-aha

🕑 Publishing the following connectors:
connectors/source-aha
https://github.com/airbytehq/airbyte/actions/runs/3466887788

Connector	Did it publish?	Were definitions generated?
connectors/source-aha	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm

thanks @bala-ceg

bala-ceg · 2022-11-15T02:56:38Z

Thanks @marcosmarxm for helping me merge this connector

* 🎉 New Source: Aha * addressing the comments * addressing review comments * addressing review comments & removing newly added EoL * fixing end of file line * fixing end of file line * including paginator * Fixing the pagination issue * Removing the contents from sample_config.json * fix schema, tests and add aha to source def * format files * auto-bump connector version Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

github-actions bot added the area/connectors Connector related issues label Nov 3, 2022

octavia-squidington-iv added bounty community connectors/source/aha labels Nov 3, 2022

bala-ceg mentioned this pull request Nov 3, 2022

New Source: Aha airbytehq/connector-contest#263

Closed

marcosmarxm added the hacktober label Nov 3, 2022

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 7, 2022

marcosmarxm requested changes Nov 7, 2022

View reviewed changes

bala-ceg requested a review from marcosmarxm November 8, 2022 07:51

marcosmarxm requested changes Nov 9, 2022

View reviewed changes

airbyte-integrations/connectors/source-aha/source_aha/aha.yaml Show resolved Hide resolved

bala-ceg mentioned this pull request Nov 10, 2022

Low code CDK: With PageIncrement as page strategy, page_token_option is not injected into request parameter #19274

Closed

bala-ceg requested a review from marcosmarxm November 10, 2022 03:57

bala-ceg and others added 11 commits November 14, 2022 22:45

🎉 New Source: Aha

929ab6b

addressing the comments

c3b8e44

addressing review comments

38c68c4

addressing review comments & removing newly added EoL

44bce39

fixing end of file line

f73a07f

fixing end of file line

cec12ef

including paginator

94bb173

Fixing the pagination issue

30ee952

Removing the contents from sample_config.json

a022c6c

fix schema, tests and add aha to source def

321bf35

format files

2dcff75

marcosmarxm force-pushed the aha branch from c60e23e to 2dcff75 Compare November 15, 2022 01:45

auto-bump connector version

6abf691

marcosmarxm approved these changes Nov 15, 2022

View reviewed changes

marcosmarxm merged commit 4fbd061 into airbytehq:master Nov 15, 2022

RealChrisSean added the low-code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

marcosmarxm changed the title ~~🎉 New Source: Aha~~ 🎉 New Source: Aha [low-code cdk] Nov 18, 2022

sajarin added internal and removed bounty labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: Aha [low-code cdk] #18893

🎉 New Source: Aha [low-code cdk] #18893

bala-ceg commented Nov 3, 2022 •

edited

Loading

marcosmarxm commented Nov 4, 2022

marcosmarxm commented Nov 4, 2022

bala-ceg commented Nov 7, 2022

marcosmarxm left a comment

bala-ceg commented Nov 9, 2022

marcosmarxm left a comment

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

bala-ceg commented Nov 15, 2022

Build Failed

marcosmarxm commented Nov 15, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 15, 2022 •

edited by github-actions bot

Loading

marcosmarxm left a comment

bala-ceg commented Nov 15, 2022

🎉 New Source: Aha [low-code cdk] #18893

🎉 New Source: Aha [low-code cdk] #18893

Conversation

bala-ceg commented Nov 3, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Tests

marcosmarxm commented Nov 4, 2022

marcosmarxm commented Nov 4, 2022

bala-ceg commented Nov 7, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

bala-ceg commented Nov 9, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 14, 2022 • edited by github-actions bot Loading

Build Failed

bala-ceg commented Nov 15, 2022

Build Failed

marcosmarxm commented Nov 15, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 15, 2022 • edited by github-actions bot Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

bala-ceg commented Nov 15, 2022

bala-ceg commented Nov 3, 2022 •

edited

Loading

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 15, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 15, 2022 •

edited by github-actions bot

Loading