Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Add typings to mock data #19022

Merged
merged 4 commits into from
Nov 7, 2022
Merged

🪟 🔧 Add typings to mock data #19022

merged 4 commits into from
Nov 7, 2022

Conversation

josephkmh
Copy link
Contributor

What

  • Refactors mockConnection, mockDestination and mockWorkspace from JSON to typescript objects

This gives us strong typings in test files so we don't have to do any casting when using them. It also should help catch any errors if the backend changes data shapes that would break our frontend test assumptions.

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 7, 2022
@josephkmh josephkmh marked this pull request as ready for review November 7, 2022 11:50
@josephkmh josephkmh requested a review from a team as a code owner November 7, 2022 11:50
timroes
timroes approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, have not checked out locally

@josephkmh josephkmh merged commit 41a12f6 into master Nov 7, 2022
@josephkmh josephkmh deleted the joey/mock-data-to-typescript branch November 7, 2022 14:34
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephkmh @timroes