🪟 🎨 Connector Builder light yaml editor theme #19100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
timroes
reviewed
Nov 8, 2022
| @@ -15,7 +14,7 @@ const queryClient = new QueryClient({ | |||
|
|
|||
| const StoreProvider: React.FC<React.PropsWithChildren<unknown>> = ({ children }) => ( | |||
| <QueryClientProvider client={queryClient}> | |||
| <ReactQueryDevtools initialIsOpen={false} position="bottom-right" /> | |||
| {/* <ReactQueryDevtools initialIsOpen={false} position="bottom-right" /> */} | |||
There was a problem hiding this comment.
Specific reason we commented this out?
There was a problem hiding this comment.
Oops, didn't mean to commit that. I had just commented it out while taking a screenshot to not detract from the color-focused demonstration :p
Will undo this
timroes
approved these changes
Nov 8, 2022
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
* switch to light theme for yaml editor * adjust colors again * rename colors * fix config menu theme * use gradient again for background * undo change to comment out react query dev tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Now that the Airbyte UI's theme has been updated to be a bit brighter, I felt that the Connector Builder yaml editor's dark theme no longer fit well with the rest of the Airbyte UI's colors.
This PR adds a new "airbyte-light" theme to our wrapped monaco editor and uses that in the connector builder, so that it matches better with Airbyte's new theme.
How
Defining a new monaco editor theme in code, exporting colors from the scss file.
Screenshot from BEFORE these changes:
Screenshot AFTER these changes:
🚨 User Impact 🚨
New look for embedded yaml editor in connector builder