Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump marketplace actions due to deprecations #19126

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

cuyk
Copy link
Contributor

@cuyk cuyk commented Nov 8, 2022

What

set-output GitHub Actions directive is deprecated and will be fully disabled on 31st May 2023.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
node12 is deprecated as well and should be switched to node16

How

Update actions/cache, actions/checkout, actions/setup-java, actions/setup-node, actions/setup-python and docker/login-action to the latest versions.

@cuyk cuyk force-pushed the vova/3161-update-marketplace-actions-due-deprecations branch from bba66bb to 25decc3 Compare November 9, 2022 10:32
with:
distribution: "zulu"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the default distribution in v1 action.

@cuyk cuyk temporarily deployed to more-secrets November 9, 2022 10:34 Inactive
@cuyk cuyk marked this pull request as ready for review November 9, 2022 10:36
@cuyk cuyk requested review from supertopher and a team November 9, 2022 10:36
@cuyk cuyk force-pushed the vova/3161-update-marketplace-actions-due-deprecations branch from 25decc3 to 5d74347 Compare November 9, 2022 11:56
@cuyk cuyk temporarily deployed to more-secrets November 9, 2022 11:59 Inactive
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me

@cuyk cuyk force-pushed the vova/3161-update-marketplace-actions-due-deprecations branch from 5d74347 to 59da3e2 Compare November 10, 2022 10:52
@cuyk cuyk temporarily deployed to more-secrets November 10, 2022 10:54 Inactive
@cuyk cuyk force-pushed the vova/3161-update-marketplace-actions-due-deprecations branch from 59da3e2 to a9aa74c Compare November 10, 2022 11:13
@cuyk cuyk temporarily deployed to more-secrets November 10, 2022 11:16 Inactive
@cuyk cuyk force-pushed the vova/3161-update-marketplace-actions-due-deprecations branch from a9aa74c to 59da67b Compare November 10, 2022 12:01
@cuyk cuyk temporarily deployed to more-secrets November 10, 2022 12:02 Inactive
@cuyk cuyk merged commit 7454a42 into master Nov 10, 2022
@cuyk cuyk deleted the vova/3161-update-marketplace-actions-due-deprecations branch November 10, 2022 14:01
with:
disribution: "zulu"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Typo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants