Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Increase LaunchDarkly initialization timeout #19204

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Nov 9, 2022

What

Increase the LaunchDarkly timeout which we'll wait for initialization. This is mostly a security mechanism to prevent failing (or slowing down completely) the app in case LD doesn't work. 1.5s was rather low and we saw it already on slower internet connections not initializing, thus increasing to 5s.

@timroes timroes added team/compose area/frontend Related to the Airbyte webapp ui/services labels Nov 9, 2022
@timroes timroes requested a review from a team as a code owner November 9, 2022 09:14
@github-actions github-actions bot added the area/platform issues related to the platform label Nov 9, 2022
@timroes timroes changed the title Increase LaunchDarkly initialization timeout 🪟 🔧 Increase LaunchDarkly initialization timeout Nov 9, 2022
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/compose
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants