Source File: using AirbyteConnectionStatus for "check" command instead of Exception #19222

grubberr · 2022-11-09T14:47:53Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Try to fix this oncall https://github.com/airbytehq/oncall/issues/1007

Improve validation on "check" command to return AirbyteConnectionStatus instead of Exception
It will improve UX experience and skip generating sentry exception and on-call issues

P.S. somebody published airbyte/source-file:0.2.29, I have bumped version to 0.2.30

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-11-09T14:48:30Z

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3429174639
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3429174639
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       280     40    86%
source_file/utils.py         13      5    62%
source_file/source.py        78     43    45%
---------------------------------------------
TOTAL                       373     88    76%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        78      7    91%
source_file/client.py       280     37    87%
---------------------------------------------
TOTAL                       373     45    88%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              345    110    68%   53, 64-72, 77-84, 88-89, 93-94, 178, 216-233, 242-250, 254-259, 265, 298-303, 341-348, 391-393, 396, 461-469, 481-484, 489, 545-546, 552, 555, 591-601, 614-639
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1508    348    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
============ 26 passed, 1 skipped, 27 warnings in 64.18s (0:01:04) =============

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-11-09T15:12:52Z

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3429375226
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/3429375226
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       280     40    86%
source_file/utils.py         13      5    62%
source_file/source.py        78     43    45%
---------------------------------------------
TOTAL                       373     88    76%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/utils.py         13      1    92%
source_file/source.py        78      7    91%
source_file/client.py       280     37    87%
---------------------------------------------
TOTAL                       373     45    88%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              345    110    68%   53, 64-72, 77-84, 88-89, 93-94, 178, 216-233, 242-250, 254-259, 265, 298-303, 341-348, 391-393, 396, 461-469, 481-484, 489, 545-546, 552, 555, 591-601, 614-639
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1508    348    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
============ 26 passed, 1 skipped, 27 warnings in 61.53s (0:01:01) =============

grubberr · 2022-11-10T11:49:00Z

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/3436533452

Connector	Did it publish?	Were definitions generated?
connectors/source-file	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-11-10T12:09:55Z

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/3436675162

Connector	Did it publish?	Were definitions generated?
connectors/source-file	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

grubberr · 2022-11-10T12:31:17Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/3436815553

Connector	Did it publish?	Were definitions generated?
connectors/source-file-secure	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-11-10T13:04:02Z

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/3437031330

Connector	Did it publish?	Were definitions generated?
connectors/source-file-secure	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…d of Exception (#19222)

use ConfigurationError in _validate_and_transform

fe89d39

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/connectors Connector related issues label Nov 9, 2022

octavia-squidington-iv added the connectors/source/file label Nov 9, 2022

grubberr changed the title ~~Source File: improve config validation for "check" command~~ Source File: using AirbyteConnectionStatus for "check" command instead of Exception Nov 9, 2022

file.md updated

7de52f4

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 9, 2022

Dockerfile updated

f03a7b1

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iv added the connectors/source/file-secure label Nov 9, 2022

grubberr requested a review from darynaishchenko November 9, 2022 15:02

grubberr self-assigned this Nov 9, 2022

grubberr requested a review from arsenlosenko November 9, 2022 15:04

darynaishchenko approved these changes Nov 10, 2022

View reviewed changes

Merge branch 'master' into grubberr/oncall-1007-source-file

3f16b13

bump 0.2.30

7998a91

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

auto-bump connector version

66dde97

octavia-squidington-iii temporarily deployed to more-secrets November 10, 2022 12:33 Inactive

Merge branch 'master' into grubberr/oncall-1007-source-file

160c0d1

grubberr temporarily deployed to more-secrets November 10, 2022 13:03 Inactive

exception -> failed

2c0e0e3

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr temporarily deployed to more-secrets November 10, 2022 13:05 Inactive

alafanechere merged commit fce9184 into master Nov 10, 2022

alafanechere deleted the grubberr/oncall-1007-source-file branch November 10, 2022 13:22

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

akashkulk pushed a commit that referenced this pull request Dec 2, 2022

Source File: using AirbyteConnectionStatus for "check" command instea…

8017f16

…d of Exception (#19222)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source File: using AirbyteConnectionStatus for "check" command instead of Exception #19222

Source File: using AirbyteConnectionStatus for "check" command instead of Exception #19222

grubberr commented Nov 9, 2022 •

edited

Loading

grubberr commented Nov 9, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 9, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 10, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 10, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 10, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 10, 2022 •

edited by github-actions bot

Loading

Source File: using AirbyteConnectionStatus for "check" command instead of Exception #19222

Source File: using AirbyteConnectionStatus for "check" command instead of Exception #19222

Conversation

grubberr commented Nov 9, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Nov 9, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Nov 9, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Nov 10, 2022 • edited by github-actions bot Loading

grubberr commented Nov 10, 2022 • edited by github-actions bot Loading

grubberr commented Nov 10, 2022 • edited by github-actions bot Loading

grubberr commented Nov 10, 2022 • edited by github-actions bot Loading

grubberr commented Nov 9, 2022 •

edited

Loading

grubberr commented Nov 9, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 9, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 10, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 10, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 10, 2022 •

edited by github-actions bot

Loading

grubberr commented Nov 10, 2022 •

edited by github-actions bot

Loading