Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: Demo - Youtube Analytics Business #19223

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Nov 9, 2022

What

Resolving: #19017

@bazarnov bazarnov requested a review from a team as a code owner November 9, 2022 14:55
@github-actions github-actions bot added area/connectors Connector related issues area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 9, 2022
@bazarnov
Copy link
Collaborator Author

bazarnov commented Nov 9, 2022

/test connector=connectors/source-youtube-analytics-business

🕑 connectors/source-youtube-analytics-business https://github.com/airbytehq/airbyte/actions/runs/3429236324
✅ connectors/source-youtube-analytics-business https://github.com/airbytehq/airbyte/actions/runs/3429236324
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              345    110    68%   53, 64-72, 77-84, 88-89, 93-94, 178, 216-233, 242-250, 254-259, 265, 298-303, 341-348, 391-393, 396, 461-469, 481-484, 489, 545-546, 552, 555, 591-601, 614-639
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1508    348    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:65: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:243: The previous connector image could not be retrieved.
================== 21 passed, 5 skipped, 26 warnings in 8.61s ==================

@bazarnov bazarnov temporarily deployed to more-secrets November 9, 2022 14:56 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Nov 9, 2022

/publish connector=connectors/source-youtube-analytics-business

🕑 Publishing the following connectors:
connectors/source-youtube-analytics-business
https://github.com/airbytehq/airbyte/actions/runs/3429356397


Connector Did it publish? Were definitions generated?
connectors/source-youtube-analytics-business

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets November 9, 2022 15:29 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets November 9, 2022 15:44 Inactive
@bazarnov bazarnov merged commit e4bb0b9 into master Nov 9, 2022
@bazarnov bazarnov deleted the baz/demo-case-youtube-analytics-business branch November 9, 2022 15:44
@girarda
Copy link
Contributor

girarda commented Nov 9, 2022

@bazarnov is this new source temporary?

An alternative to copying the source would've been to create and publish a docker image with your change and point to it in source_definitions

@bazarnov
Copy link
Collaborator Author

bazarnov commented Nov 9, 2022

It's temp changes, yes. I'll revert them right after we get approval.

@timroes
Copy link
Collaborator

timroes commented Nov 9, 2022

@bazarnov Even if you make temporary changes like this, please make sure you wait for the CI run to finish before merging, so we're not running into the risk of breaking master due to some bad commit. (e.g. a single space too much/less in the frontend code would fail our code formatting checks).

@bazarnov
Copy link
Collaborator Author

bazarnov commented Nov 9, 2022

Got your point, I've made additional tests for airbyte-webapp with npm, to ensure it builds and runs correctly locally, in the first place, before merging this one. so we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/frontend Related to the Airbyte webapp area/platform issues related to the platform connectors/source/youtube-analytics-business
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants