Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out Temporal errors from SyncWorkflowImpl #19293

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Filter out Temporal errors from SyncWorkflowImpl #19293

merged 2 commits into from
Nov 10, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Filter unexceptional errors from APM traces

How

  • Filter out the DestroyWorkflowThreadError that Temporal uses to stop a workflow from SyncWorkflowImpl traces

Recommended reading order

  1. TemporalSdkInterceptor.java

Tests

  • All tests pass
  • Tests updated to filter for SyncWorkflowImpl
  • Project builds successfully

@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 10, 2022 17:42 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 10, 2022 17:44 Inactive
@jdpgrailsdev jdpgrailsdev merged commit 6b92151 into master Nov 10, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/filter-traces branch November 10, 2022 18:40
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
@jdpgrailsdev @akashkulk
Filter out Temporal errors from SyncWorkflowImpl (#19293)
d898d33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

@gosusnp gosusnp gosusnp approved these changes

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdpgrailsdev @gosusnp @benmoriceau