CDK: don't filter failed interpolated vars for request_options_provider.request_body_json
#19297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
grubberr
changed the title
request_options_provider.request_body_jsonrequest_options_provider.request_body_json
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
girarda
reviewed
Nov 11, 2022
| ("test_integer_falsy_value", {"integer_falsy": "{{ 0 }}"}, {"integer_falsy": 0}), | ||
| ("test_number_falsy_value", {"number_falsy": "{{ 0.0 }}"}, {"number_falsy": 0.0}), | ||
| ("test_string_falsy_value", {"string_falsy": "{{ '' }}"}, {"string_falsy": None}), | ||
| ("test_none_value", {"none_value": "{{ None }}"}, {"none_value": None}), |
There was a problem hiding this comment.
when would we want to return None in the request body?
There was a problem hiding this comment.
In theory I can imagine something like this:
curl -d '{"key1":null}' -X POST http://api.com/api
But to be honest we did not encounter in this for now. For now we need only this:
curl -d '{"key1":false}' -X POST http://api.com/api
I have re-implemented doing less radical changes
What do you think now?
…ut_provider Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
girarda
approved these changes
Nov 11, 2022
…ut_provider Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
|
/publish-cdk dry-run=false
|
grubberr
deleted the
grubberr/cdk-json-interpolated_request_input_provider
branch
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
…der.request_body_json` (#19297) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Chvalyuk grubberr@gmail.com
What
In current implementation of Interpolation this does not work:
key1,key2will be removed because of this:https://github.com/airbytehq/airbyte/blob/master/airbyte-cdk/python/airbyte_cdk/sources/declarative/requesters/request_options/interpolated_request_input_provider.py#L48
I propose do this "empty value" filtering only for:
request_options_provider.get_request_paramsrequest_options_provider.get_request_headersrequest_options_provider.get_request_body_databut for
request_options_provider.request_body_jsonskip this filtering