Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set app_id in snowflake source connector based on oss/cloud #19314

Merged
merged 8 commits into from
Nov 11, 2022

Conversation

akashkulk
Copy link
Contributor

@akashkulk akashkulk commented Nov 10, 2022

Set app_id in snowflake source connector based on env (OSS/Cloud)

Closes #19249

Set app_id in snowflake source connector based on
@akashkulk
Copy link
Contributor Author

akashkulk commented Nov 10, 2022

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3440822896
❌ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3440822896
🐛 https://gradle.com/s/sflcrmpgrl5ok

Build Failed

Test summary info:

Could not find result summary

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector version
  • Add changelog
  • Publish the new version

✅ Sources (1)

Connector Version Changelog Publish
source-snowflake 0.1.26
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@akashkulk
Copy link
Contributor Author

akashkulk commented Nov 10, 2022

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3441207441
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/3441207441
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 29.22s ==================

@akashkulk akashkulk requested review from edgao and etsybaev November 10, 2022 23:30
.withOssSource(() -> new SnowflakeSource(AIRBYTE_OSS))
.withCloudSource(() -> new SnowflakeSource(AIRBYTE_CLOUD))
.run(args);
SCHEDULED_EXECUTOR_SERVICE.shutdownNow();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, I totally forgot about this on the destination-snowflake PR

@akashkulk
Copy link
Contributor Author

akashkulk commented Nov 11, 2022

/publish connector=connectors/source-snowflake run-tests=false

🕑 Publishing the following connectors:
connectors/source-snowflake
https://github.com/airbytehq/airbyte/actions/runs/3441500899


Connector Did it publish? Were definitions generated?
connectors/source-snowflake

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets November 11, 2022 00:39 Inactive
@akashkulk akashkulk temporarily deployed to more-secrets November 11, 2022 00:53 Inactive
@akashkulk akashkulk marked this pull request as ready for review November 11, 2022 00:54
@akashkulk akashkulk requested a review from a team as a code owner November 11, 2022 00:54
@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 11, 2022
@akashkulk akashkulk temporarily deployed to more-secrets November 11, 2022 01:10 Inactive
@akashkulk akashkulk merged commit cbb2e98 into master Nov 11, 2022
@akashkulk akashkulk deleted the snowflake_appid branch November 11, 2022 01:24
akashkulk added a commit that referenced this pull request Dec 2, 2022
* Set app_id in snowflake source connector based on oss/cloud

Set app_id in snowflake source connector based on

* Bump version + docs

* auto-bump connector version

* Formatting

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/snowflake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snowflake source should set application ID in JDBC param
4 participants