🪟 🐛 Fix showing reset dialog after refresh source

[timroes]

What

Fixes a problem with the reset modal not showing after a user refreshed their source schema.

How

Since #16748 we updated the connection in ConnectionEditService, which is later when submitting used to compare against the form values to detect if there's a change in the catalog. Since it now always contained the updated (refreshed) connection, it would no longer diff from the form values just because of a refreshed catalog and thus the reset modal wouldn't show.

Sicne we now have the catalogDiff on that connection after refreshing I added logic to check if any of the transforms in this affects an enabled stream and if so show the reset modal again.

[teallarson]

code looks good and tested locally, this solves the problem outlined

[josephkmh]

Code LGTM - but looks like a place that would be useful to have a test to avoid another regression. WDYT?

[timroes]

but looks like a place that would be useful to have a test to avoid another regression. WDYT?

I agree. We have that on the list of e2e tests we still want to add, since testing this in a unit test did require too mock way too much to actually still have realistic meaningful tests for it, since those detections (or the data delivered there) are build from several APIs and require to kind of run the whole connection form to be in a somewhat realistic state. cc @ambirdsall Would be great if we can keep track of adding some e2e tests for the reset dialogs, if we don't have this already tracked.