Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Zendesk Support: do not use nonpublic API #19432

Merged
merged 12 commits into from
Nov 29, 2022
Merged

Source Zendesk Support: do not use nonpublic API #19432

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1954209
#1010 oncall Source Zendesk Support: do not use nonpublic API
davydov-d Nov 15, 2022
868d373
#1010 source zendesk-support: upd changelog
davydov-d Nov 15, 2022
ca5e0fb
Merge branch 'master' into ddavydov/#1010-zendesk-support-do-not-use-…
davydov-d Nov 16, 2022
bbaccfe
Merge branch 'master' into ddavydov/#1010-zendesk-support-do-not-use-…
davydov-d Nov 21, 2022
bad769d
#1010 source zendesk-support: log an error during discover
davydov-d Nov 21, 2022
7686eb1
#1010 source zendesk support: fix unit test
davydov-d Nov 21, 2022
0bf558a
#1010 source zendesk support: fix expected records
davydov-d Nov 23, 2022
2bac3a7
Merge branch 'master' into ddavydov/#1010-zendesk-support-do-not-use-…
davydov-d Nov 29, 2022
321b00a
#1010 source zendesk support: upd expected records
davydov-d Nov 29, 2022
5c35d0d
#1010 source zendesk support: another records update
davydov-d Nov 29, 2022
f24172e
Merge branch 'master' into ddavydov/#1010-zendesk-support-do-not-use-…
davydov-d Nov 29, 2022
3daf536
auto-bump connector version
octavia-squidington-iii Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-zendesk-support/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@ COPY source_zendesk_support ./source_zendesk_support
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.16
LABEL io.airbyte.version=0.2.17
LABEL io.airbyte.name=airbyte/source-zendesk-support
48 changes: 28 additions & 20 deletions airbyte-integrations/connectors/source-zendesk-support/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,37 @@
# See [Source Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/source-acceptance-tests-reference)
# for more information about how to configure these tests
connector_image: airbyte/source-zendesk-support:dev
tests:
test_strictness_level: high
acceptance_tests:
spec:
- spec_path: "source_zendesk_support/spec.json"
tests:
- spec_path: "source_zendesk_support/spec.json"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "secrets/config_oauth.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "secrets/config_oauth.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
- config_path: "secrets/config_oauth.json"
tests:
- config_path: "secrets/config.json"
- config_path: "secrets/config_oauth.json"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: ["tags"]
tests:
- config_path: "secrets/config.json"
expect_records:
path: "integration_tests/expected_records.txt"
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
future_state_path: "integration_tests/abnormal_state.json"
cursor_paths:
ticket_comments: ["created_at"]
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/incremental_catalog.json"
future_state:
future_state_path: "integration_tests/abnormal_state.json"
cursor_paths:
ticket_comments: ["created_at"]
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
26 changes: 13 additions & 13 deletions ...-integrations/connectors/source-zendesk-support/integration_tests/configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -21,7 +21,7 @@
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -33,7 +33,7 @@
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -45,7 +45,7 @@
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -57,7 +57,7 @@
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand Down Expand Up @@ -101,7 +101,7 @@
"default_cursor_field": ["created_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -113,7 +113,7 @@
"default_cursor_field": ["created_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -125,7 +125,7 @@
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -137,7 +137,7 @@
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -149,7 +149,7 @@
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -161,7 +161,7 @@
"default_cursor_field": ["time"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -173,7 +173,7 @@
"default_cursor_field": ["generated_timestamp"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
},
{
Expand All @@ -185,7 +185,7 @@
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"sync_mode": "full_refresh",
"destination_sync_mode": "append"
}
]
Expand Down
116 changes: 116 additions & 0 deletions ...yte-integrations/connectors/source-zendesk-support/integration_tests/expected_records.txt
View file
Open in desktop

Large diffs are not rendered by default.

160 changes: 160 additions & 0 deletions ...integrations/connectors/source-zendesk-support/integration_tests/incremental_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
{
"streams": [
{
"stream": {
"name": "group_memberships",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "groups",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "macros",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "organizations",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "satisfaction_ratings",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "ticket_audits",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["created_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "ticket_comments",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["created_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "ticket_fields",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "ticket_forms",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "ticket_metrics",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "ticket_metric_events",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["time"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "tickets",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["generated_timestamp"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "users",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"destination_sync_mode": "append"
}
]
}
Loading