Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAT: do not treat spec fields with const values as the ones that can hold secrets #19465

Merged
merged 2 commits into from
Nov 16, 2022
Merged

SAT: do not treat spec fields with const values as the ones that can hold secrets #19465

merged 2 commits into from
Nov 16, 2022

Conversation

davydov-d
Copy link
Collaborator

What

SAT: when looking for specification properties that potentially can hold a secret value, we count constants as well

How

Do not treat these fields as the ones that can hold a secret

@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 16, 2022 •
edited by github-actions bot
Loading

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3477875545
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/3477875545
No Python unittests run

Build Passed

Test summary info:

All Passed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022 •
edited
Loading

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector version
  • Add changelog
  • Publish the new version

❌ Sources (64)
Connector Version Changelog Publish
source-airtable 0.1.3 ✅ ✅
source-amazon-ads 0.1.25 ✅ ✅
source-amazon-seller-partner 0.2.28 ✅ ✅
source-amazon-sqs 0.1.0 ✅ ✅
source-amplitude 0.1.17 ✅ ✅
source-appsflyer 0.1.0 ⚠
(doc not found)		 ⚠
(not in seed)
source-asana 0.1.4 ✅ ✅
source-azure-table 0.1.3 ✅ ✅
source-braintree 0.1.3 ✅ ✅
source-cart 0.2.0 ❌
(changelog missing)		 ✅
source-chargebee 0.1.16 ✅ ❌
(diff seed version)
source-commercetools 0.1.0 ✅ ✅
source-confluence 0.1.1 ✅ ✅
source-datadog 0.1.0 ✅ ✅
source-delighted 0.1.4 ✅ ✅
source-drift 0.2.5 ✅ ✅
source-facebook-marketing 0.2.72 ✅ ✅
source-facebook-pages 0.1.6 ✅ ✅
source-freshcaller 0.1.0 ✅ ✅
source-freshsales 0.1.2 ✅ ✅
source-freshservice 0.1.1 ✅ ✅
source-github 0.3.8 ✅ ✅
source-gitlab 0.1.6 ✅ ✅
source-google-ads 0.2.4 ✅ ✅
source-google-search-console 0.1.18 ✅ ✅
source-greenhouse 0.3.0 ✅ ✅
source-harvest 0.1.11 ✅ ✅
source-instagram 1.0.0 ✅ ✅
source-iterable 0.1.21 ✅ ✅
source-klaviyo 0.1.10 ✅ ✅
source-lemlist 0.1.1 ❌
(changelog missing)		 ❌
(diff seed version)
source-lever-hiring 0.1.3 ✅ ✅
source-linnworks 0.1.5 ❌
(changelog missing)		 ✅
source-mailchimp 0.2.15 ✅ ✅
source-mailgun 0.1.0 ⚠
(doc not found)		 ✅
source-monday 0.1.4 ✅ ✅
source-notion 0.1.10 ✅ ✅
source-okta 0.1.13 ✅ ✅
source-onesignal 0.1.2 ✅ ✅
source-openweather 0.1.6 ✅ ✅
source-outreach 0.1.2 ✅ ✅
source-pardot 0.1.0 ⚠
(doc not found)		 ⚠
(not in seed)
source-paystack 0.1.1 ✅ ✅
source-pinterest 0.1.9 ✅ ✅
source-pipedrive 0.1.13 ✅ ✅
source-plaid 0.3.2 ❌
(changelog missing)		 ✅
source-posthog 0.1.7 ✅ ✅
source-prestashop 0.3.0 ⚠
(doc not found)		 ✅
source-quickbooks-singer 0.1.5 ⚠
(doc not found)		 ✅
source-recharge 0.2.4 ❌
(changelog missing)		 ✅
source-retently 0.1.2 ✅ ✅
source-salesforce 1.0.26 ✅ ✅
source-salesloft 0.1.3 ✅ ✅
source-sendgrid 0.2.16 ✅ ✅
source-sentry 0.1.7 ✅ ✅
source-strava 0.1.2 ✅ ✅
source-surveymonkey 0.1.11 ✅ ✅
source-tplcentral 0.1.1 ✅ ⚠
(not in seed)
source-twilio 0.1.13 ✅ ✅
source-weatherstack 0.1.0 ✅ ✅
source-youtube-analytics 0.1.3 ✅ ✅
source-zendesk-sunshine 0.1.1 ✅ ✅
source-zendesk-talk 0.1.5 ✅ ✅
source-zenloop 0.1.3 ✅ ✅
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)
Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)
Category Status Actionable Item
Version ❌
mismatch		 The version of the connector is different from its normal variant. Please bump the version of the connector.
⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog ⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
❌
changelog missing		 There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish ⚠
not in seed		 The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
❌
diff seed version		 The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 16, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/3477878807
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/3477878807
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_zendesk_support/__init__.py       2      0   100%
source_zendesk_support/source.py        50      6    88%
source_zendesk_support/streams.py      346     42    88%
--------------------------------------------------------
TOTAL                                  398     48    88%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

All Passed

@davydov-d davydov-d mentioned this pull request Nov 16, 2022
Merged
alafanechere
alafanechere approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, minor suggestion.

airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py Show resolved Hide resolved
@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 16, 2022 •
edited by github-actions bot
Loading

/publish connector=bases/source-acceptance-test auto-bump-version=false

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/3479098232


Connector Did it publish? Were definitions generated?
bases/source-acceptance-test ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit d97e300 into master Nov 16, 2022
@davydov-d davydov-d deleted the ddavydov/SAT-constant-values-cannot-hold-secrets branch November 16, 2022 12:14
@github-actions github-actions bot mentioned this pull request Nov 17, 2022
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
@davydov-d @akashkulk
SAT: do not treat spec fields with const values as the ones that can …
c891f0d 
…hold secrets (#19465)

* SAT: do not treat spec fields with const values as the ones that can hold secrets

* sat: upd changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alafanechere alafanechere alafanechere approved these changes

@pedroslopez pedroslopez Awaiting requested review from pedroslopez

@girarda girarda Awaiting requested review from girarda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davydov-d @alafanechere