Source freshdesk - fix schema #19496

davydov-d · 2022-11-16T18:44:02Z

What

https://github.com/airbytehq/oncall/issues/1038

How

Change twitter_id type to string according to their API doc

davydov-d · 2022-11-16T18:45:48Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3482191279
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3482191279
🐛 https://gradle.com/s/j4z7z56o2w4wy

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream agent...
ERROR test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:370: Backward compatibility tests are disabled for version 0.3.8.
========= 1 failed, 28 passed, 1 skipped, 1 error in 328.39s (0:05:28) =========

girarda

lgtm but Cloud users will need to reset their data because of the schema change @YowanR @TBernstein4

davydov-d · 2022-11-21T10:15:41Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3513469257
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3513469257
🐛 https://gradle.com/s/eg3uxdodrfpxa

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream agent...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:370: Backward compatibility tests are disabled for version 0.3.8.
============= 1 failed, 29 passed, 1 skipped in 323.45s (0:05:23) ==============

davydov-d · 2022-11-21T10:52:00Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3513733973
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3513733973
🐛 https://gradle.com/s/j66d3svptlzse

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream agent...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:370: Backward compatibility tests are disabled for version 0.3.8.
============= 1 failed, 29 passed, 1 skipped in 322.50s (0:05:22) ==============

davydov-d · 2022-11-21T12:47:26Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3514531290
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3514531290
🐛 https://gradle.com/s/qaw7ceq6c23xi

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream conta...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:370: Backward compatibility tests are disabled for version 0.3.8.
============= 1 failed, 29 passed, 1 skipped in 327.05s (0:05:27) ==============

davydov-d · 2022-11-21T13:11:34Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3514691252
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3514691252
🐛 https://gradle.com/s/3zdhy5dpbpfae

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream surve...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:370: Backward compatibility tests are disabled for version 0.3.8.
============= 1 failed, 29 passed, 1 skipped in 324.11s (0:05:24) ==============

YowanR · 2022-11-21T13:54:09Z

Cc @erica-airbyte for the customer
outreach (#19496 (review)) bit.

davydov-d · 2022-11-21T14:00:03Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3515054585
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3515054585
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        31      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      221      3    99%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            274      4    99%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:370: Backward compatibility tests are disabled for version 0.3.8.
================== 30 passed, 1 skipped in 331.33s (0:05:31) ===================

erica-airbyte · 2022-11-21T15:04:07Z

@YowanR and @girarda is this ALL customers that have Freshdesk will need to run a reset?

girarda · 2022-11-21T15:10:34Z

@erica-airbyte all customers that sync the contacts stream

erica-airbyte · 2022-11-21T15:48:56Z

@girarda do we have that list of customers?

pedroslopez · 2022-11-21T16:02:51Z

@erica-airbyte just pulled the list of active connections syncing contacts - looks like two connections and one is internal:

amalia-airbyte Freshdesk <> BigQuery - Amalia Test
Worksuite Inc. Freshdesk <> Snowflake

davydov-d · 2022-11-23T08:34:26Z

/test connector=connectors/source-freshdesk

davydov-d · 2022-11-28T08:57:55Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3563204740
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3563204740
🐛 https://gradle.com/s/mnly56cknif5i

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream solut...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:370: Backward compatibility tests are disabled for version 0.3.8.
============= 1 failed, 29 passed, 1 skipped in 338.91s (0:05:38) ==============

davydov-d · 2022-11-29T09:47:05Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3572882328
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3572882328
🐛 https://gradle.com/s/wrvglgew232vg

Build Failed

Test summary info:

Could not find result summary

davydov-d · 2022-11-29T10:09:31Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3573054457
❌ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3573054457
🐛 https://gradle.com/s/tylqb3ehxddfe

Build Failed

Test summary info:

Could not find result summary

davydov-d · 2022-11-29T10:57:23Z

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3573409096
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3573409096
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        31      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      221      3    99%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            274      4    99%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:370: Backward compatibility tests are disabled for version 0.3.8.
================== 30 passed, 1 skipped in 331.18s (0:05:31) ===================

alafanechere

Approving the changes made to acceptance-test-config.yml on behalf of connector operations team. @davydov-d please sync with TCS (@erica-airbyte ) before publishing the new version to ensure they are ready to send customer outreach for reset.

davydov-d · 2022-11-29T16:02:01Z

hey @erica-airbyte I'm ready to publish and merge this change. Can you flag me when I may do it?

erica-airbyte · 2022-11-29T16:34:54Z

@davydov-d to confirm this only affects customers with the contacts stream, correct?

davydov-d · 2022-11-29T17:28:18Z

@erica-airbyte that's right

tybernstein · 2022-11-29T18:29:15Z

@davydov-d Comms have been sent out to customers. They were told the update would be deployed between 1 PM UTC - 7 PM UTC tomorrow.

davydov-d · 2022-11-30T12:54:26Z

/publish connector=connectors/source-freshdesk

🕑 Publishing the following connectors:
connectors/source-freshdesk
https://github.com/airbytehq/airbyte/actions/runs/3583463062

Connector	Did it publish?	Were definitions generated?
connectors/source-freshdesk	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

#1038 source freshdesk - fix schema

2f65752

octavia-squidington-iv added connectors/source/freshdesk area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 16, 2022

#1038 source freshdesk: upd changelog

c6b12ea

davydov-d requested review from grubberr, darynaishchenko, girarda and pedroslopez November 16, 2022 18:46

#1038 source freshdesk - remove temp file

34fcefc

darynaishchenko approved these changes Nov 17, 2022

View reviewed changes

girarda approved these changes Nov 18, 2022

View reviewed changes

davydov-d added 2 commits November 21, 2022 12:02

Merge branch 'master' into ddavydov/#1038-source-freshdesk-fix-schema

f6267c0

#1038 source freshdesk: fix tests

52d8488

#1038 source freshdesk: update expected records again

30e6635

#1038 source freshdesk: rm unstable expected record

e782e25

#1038 source freshdesk: edit another expected record

31d5cc8

#1038 source freshdesk: edit another expected record

2cda4f8

#1038 source freshdesk: fix expected records

3161f41

darynaishchenko mentioned this pull request Nov 23, 2022

Source FreshDesk: changed contacts twitted_id to string, updated acceptance-test-config… #19749

Closed

davydov-d added 2 commits November 29, 2022 11:40

Merge branch 'master' into ddavydov/#1038-source-freshdesk-fix-schema

8d7c639

#1038 source freshdesk: upd expected_records

0dc65d9

#1038 source freshdesk: resolve dependency conflict

2d0ff48

davydov-d requested a review from a team November 29, 2022 11:16

alafanechere approved these changes Nov 29, 2022

View reviewed changes

auto-bump connector version

a51c54b

davydov-d merged commit fa8ea96 into master Nov 30, 2022

davydov-d deleted the ddavydov/#1038-source-freshdesk-fix-schema branch November 30, 2022 13:19

octavia-squidington-iii temporarily deployed to more-secrets November 30, 2022 13:20 Inactive

This was referenced Nov 30, 2022

Source Freshdesk: enable high test strictness level in SAT #19153

Closed

Source Freshdesk: enable high test strictness level in SAT #19040

Closed

octavia-squidington-iii mentioned this pull request Nov 30, 2022

Bump Airbyte version from 0.40.22 to 0.40.23 #19941

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source freshdesk - fix schema #19496

Source freshdesk - fix schema #19496

davydov-d commented Nov 16, 2022

davydov-d commented Nov 16, 2022 •

edited by github-actions bot

Loading

girarda left a comment

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

YowanR commented Nov 21, 2022 •

edited

Loading

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

erica-airbyte commented Nov 21, 2022

girarda commented Nov 21, 2022

erica-airbyte commented Nov 21, 2022

pedroslopez commented Nov 21, 2022

davydov-d commented Nov 23, 2022

davydov-d commented Nov 28, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 29, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 29, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 29, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment •

edited

Loading

davydov-d commented Nov 29, 2022

erica-airbyte commented Nov 29, 2022

davydov-d commented Nov 29, 2022

tybernstein commented Nov 29, 2022

davydov-d commented Nov 30, 2022 •

edited by github-actions bot

Loading

Source freshdesk - fix schema #19496

Source freshdesk - fix schema #19496

Conversation

davydov-d commented Nov 16, 2022

What

How

davydov-d commented Nov 16, 2022 • edited by github-actions bot Loading

Build Failed

girarda left a comment

Choose a reason for hiding this comment

davydov-d commented Nov 21, 2022 • edited by github-actions bot Loading

Build Failed

davydov-d commented Nov 21, 2022 • edited by github-actions bot Loading

Build Failed

davydov-d commented Nov 21, 2022 • edited by github-actions bot Loading

Build Failed

davydov-d commented Nov 21, 2022 • edited by github-actions bot Loading

Build Failed

YowanR commented Nov 21, 2022 • edited Loading

davydov-d commented Nov 21, 2022 • edited by github-actions bot Loading

Build Passed

erica-airbyte commented Nov 21, 2022

girarda commented Nov 21, 2022

erica-airbyte commented Nov 21, 2022

pedroslopez commented Nov 21, 2022

davydov-d commented Nov 23, 2022

davydov-d commented Nov 28, 2022 • edited by github-actions bot Loading

Build Failed

davydov-d commented Nov 29, 2022 • edited by github-actions bot Loading

Build Failed

davydov-d commented Nov 29, 2022 • edited by github-actions bot Loading

Build Failed

davydov-d commented Nov 29, 2022 • edited by github-actions bot Loading

Build Passed

alafanechere left a comment • edited Loading

Choose a reason for hiding this comment

davydov-d commented Nov 29, 2022

erica-airbyte commented Nov 29, 2022

davydov-d commented Nov 29, 2022

tybernstein commented Nov 29, 2022

davydov-d commented Nov 30, 2022 • edited by github-actions bot Loading

davydov-d commented Nov 16, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

YowanR commented Nov 21, 2022 •

edited

Loading

davydov-d commented Nov 21, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 28, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 29, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 29, 2022 •

edited by github-actions bot

Loading

davydov-d commented Nov 29, 2022 •

edited by github-actions bot

Loading

alafanechere left a comment •

edited

Loading

davydov-d commented Nov 30, 2022 •

edited by github-actions bot

Loading