Fix MDC scope #19501
Merged
Fix MDC scope #19501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
|
As some of these changes are going to cause issues with #19396, can I instead incorporate the container-orchestrator changes into that PR? |
|
@colesnodgrass I didn't have time to look at your PR yet. I Think that we should merge this first since the code freeze is approaching and I don't know how long the migration to micronaut PR will take. |
colesnodgrass
approved these changes
Nov 16, 2022
gosusnp
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Address: https://github.com/airbytehq/oncall/issues/1066
We were using the Default MDC scope which made all the logs to be tagged with the wrong prefix. This is fixing it.