Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update building-a-python-destination.md #19516

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Update building-a-python-destination.md #19516

merged 2 commits into from
Nov 29, 2022

Conversation

lukehsiao
Copy link
Contributor

@lukehsiao lukehsiao commented Nov 17, 2022

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

If a user is following the documentation and used append_dedupe, they get the error:

{
  "type": "LOG",
  "log": {
    "level": "FATAL",
    "message": "1 validation error for ConnectorSpecification\nsupported_destination_sync_modes -> 2\n  value is not a valid enumeration member; permitted: 'append', 'overwrite', 'append_dedup' (type=type_error.enum; enum_values=[<DestinationSyncMode.append: 'append'>, <DestinationSyncMode.overwrite: 'overwrite'>, <DestinationSyncMode.append_dedup: 'append_dedup'>])..."
  }
}

How

Change the docs to show the right value :).

If a user used `append_dedupe`, they get the error:

```
{
  "type": "LOG",
  "log": {
    "level": "FATAL",
    "message": "1 validation error for ConnectorSpecification\nsupported_destination_sync_modes -> 2\n  value is not a valid enumeration member; permitted: 'append', 'overwrite', 'append_dedup' (type=type_error.enum; enum_values=[<DestinationSyncMode.append: 'append'>, <DestinationSyncMode.overwrite: 'overwrite'>, <DestinationSyncMode.append_dedup: 'append_dedup'>])..."
  }
}
```
@CLAassistant
Copy link

CLAassistant commented Nov 17, 2022

CLA assistant check
All committers have signed the CLA.

@octavia-squidington-iv octavia-squidington-iv added area/documentation Improvements or additions to documentation community labels Nov 17, 2022
@marcosmarxm
Copy link
Member

Hello 👋, first thank you for this amazing contribution.

We really appreciate the effort you've made to improve the project.
We ask you patience for the code review. Last month our team was focused on Hacktoberfest event and that probably left some PR without the proper feedback. And this week, due to the Thanksgiving US Holiday, most our team is out of office with their families. Another important piece of information why code won't be merge this week is: as a safety measure the core team has decided to freeze merging code to main branch to keep the release stable. Next week we'll return to you with the proper code review and update the status of your contribution.

If you have any questions feel free to send me a message in Slack!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants