[low-code cdk] break resolving reference preprocessing into its own class so it can be reused #19517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjlai
changed the title
girarda
approved these changes
Nov 17, 2022
|
/publish-cdk dry-run=false
|
girarda
deleted the
brian/separate_yaml_parsing_from_resolving_references
branch
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
…lass so it can be reused (#19517) * break resolving reference preprocessing into its own class so it can be reused * move reference resolution into the ManifestDeclarativeSource and deprecate the parser * formatting * last formatting i promise * rename * bump version Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Today we identified a bug in the connector builder server where we were not properly dereferencing values that came into the manifest request to the server. That was because Yaml parsing and dereferencing is coupled together in the YamlParser. This change move reference resolution of a manifest into the
ManifestDeclarativeSourceinstead of theYamlDeclarativeSource, because this resolution.How
Extracts the dereferencing and preprocessing logic out of the YamlParser into it's own class
ManifestReferenceResolver. And this preprocessing step is now part of the initialization of a manifest declarative source. I also got rid of the separate config parsers and consolidated the literal string parsing under the YamlDeclarativeSource because yaml parsing became trivial w/o the resolving.These changes will be uptaken by the connector builder server which should only require a version bump which will be in a follow up review
Recommended reading order
manifest_reference_resolver.pyyaml_declarative_source.pymanifest_declarative_source.py