Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding retry attempts in OSS repo workflows #19610

Conversation

Mykyta-Serbynevskyi
Copy link
Contributor

@Mykyta-Serbynevskyi Mykyta-Serbynevskyi commented Nov 18, 2022

As per https://github.com/airbytehq/airbyte-cloud/issues/3109 this PR adds retry attempts in GH workflows in airbytehq/airbyte repo.
The following retry actions were used:

https://github.com/marketplace/actions/retry-action (can be used for actions & steps)
https://github.com/marketplace/actions/retry-step (can be used for steps only)

@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 18, 2022 18:21 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 18, 2022 18:21 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi requested review from a team November 18, 2022 18:56
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi self-assigned this Nov 18, 2022
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi changed the title [Draft] Adding retry attempts in OSS repo workflows Adding retry attempts in OSS repo workflows Nov 18, 2022
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi marked this pull request as ready for review November 18, 2022 18:56
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks solid to me, I think we are safe to merge as long as you have seen this run once.

Copy link
Contributor

@git-phu git-phu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

just one question

.github/workflows/publish-command.yml Outdated Show resolved Hide resolved
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi force-pushed the mserbynevskyi/3109-adding-retry-attempts-to-OSS-repo-workflows branch from 8684589 to 259a8c1 Compare November 18, 2022 22:45
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 18, 2022 22:47 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 18, 2022 22:47 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 21, 2022 10:17 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 21, 2022 10:17 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 21, 2022 13:48 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 21, 2022 13:49 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 29, 2022 11:09 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi temporarily deployed to more-secrets November 29, 2022 11:09 Inactive
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi merged commit db8024a into master Nov 29, 2022
@Mykyta-Serbynevskyi Mykyta-Serbynevskyi deleted the mserbynevskyi/3109-adding-retry-attempts-to-OSS-repo-workflows branch November 29, 2022 14:23
@davydov-d
Copy link
Collaborator

Hey team, this PR brings in an unexpected behavior as for me.
Looks like fail-fast: false + retries (correct me if I'm wrong) make long failing builds even longer. I bet we should only retry transient errors.
This one was killed due to a timeout (240 mins):
https://github.com/airbytehq/airbyte/actions/runs/3648925714/jobs/6162969779 - the reason is the tests are not passing.

Is it possible to alter the workflows so they would not run that long?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants