Extend template for the Java JDBC template by SAT SPEC #19660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/connectors
Affected Connector ReportNOTE
|
| Connector | Version | Changelog | Publish |
|---|---|---|---|
source-scaffold-java-jdbc |
0.1.0 |
⚠ (doc not found) |
⚠ (not in seed) |
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Destinations (0)
| Connector | Version | Changelog | Publish |
|---|
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Other Modules (0)
Actionable Items
(click to expand)
| Category | Status | Actionable Item |
|---|---|---|
| Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
| ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
| Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
| ❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
| Publish | ⚠ not in seed |
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. |
| ❌ diff seed version |
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version. |
DoNotPanicUA
requested review from
alafanechere,
evantahler and
a team
and removed request for
a team
alafanechere
requested changes
Nov 21, 2022
...tions/connector-templates/source-java-jdbc/src/test-integration/resources/expected_spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connector-templates/source-java-jdbc/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connector-templates/source-java-jdbc/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connector-templates/source-java-jdbc/acceptance-test-docker.sh
Show resolved
Hide resolved
airbyte-integrations/connector-templates/source-java-jdbc/integration_tests/acceptance.py
Show resolved
Hide resolved
…into aleonets/19130-extend-template
alafanechere
requested changes
Nov 29, 2022
There was a problem hiding this comment.
As I mentionned, most of the file you created are already existing in an exact same format under airbyte-integrations/connector-templates/source-python/integration_tests.
For simpler maintenance, I would prefer you pick one of the following approach:
- Change the
plopfile.jsto makeJava JDBC Sourceuse thesource-python/integration_testsfiles - Create a symlink in
source-java-jdbc/integration-teststosource-python/integration-tests - Rework the
connector-templatesdirectory structure to declare files common to bothsource-pythonandsource-java-jdbcand handle this with theplopfile.js
I don't want to be a blocker on this. I'd love to get the opinion of someone else on the team.
(please format the files 😄 I know you still have new lines in stock to add these to the end of your files)
airbyte-integrations/connector-templates/source-java-jdbc/acceptance-test-docker.sh.hbs
Outdated
Show resolved
Hide resolved
airbyte-integrations/connector-templates/source-java-jdbc/integration_tests/acceptance.py.hbs
Outdated
Show resolved
Hide resolved
...egrations/connector-templates/source-java-jdbc/integration_tests/configured_catalog.json.hbs
Outdated
Show resolved
Hide resolved
...tions/connector-templates/source-java-jdbc/integration_tests/configured_catalog_inc.json.hbs
Outdated
Show resolved
Hide resolved
...ntegrations/connector-templates/source-java-jdbc/integration_tests/expected_records.json.hbs
Outdated
Show resolved
Hide resolved
airbyte-integrations/connector-templates/source-java-jdbc/integration_tests/sat-config.json.hbs
Outdated
Show resolved
Hide resolved
...ns/connector-templates/source-java-jdbc/src/test-integration/resources/dummy_config.json.hbs
Outdated
Show resolved
Hide resolved
DoNotPanicUA
changed the title
DoNotPanicUA
changed the title
|
@alafanechere |
alafanechere
approved these changes
Dec 1, 2022
airbyte-integrations/connector-templates/source-java-jdbc/acceptance-test-docker.sh
Outdated
Show resolved
Hide resolved
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update Java JDBC source template to enable SAT SPEC by default for generated sources.
#19130
Test
Steps to reproduce:
-x testas there is no implementation inside)acceptance-test-docker.shResult:
