Add failure origins to APM trace #19665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpgrailsdev
requested review from
colesnodgrass,
gosusnp,
benmoriceau and
alovew
octavia-squidington-iv
added
area/platform
benmoriceau
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
nullconditionsRecommended reading order
FailureReason.yamlFailureHelper.javaJobCreationAndStatusUpdateActivityImpl.javaTests
nullconditionsN.B. This is a second attempt to apply #19550 after @benmoriceau discovered it caused a NPE when manually terminating a workflow via the Temporal UI. This lead us to discover that we don't set a failure origin when an unexpected exception is handled by the parent workflow. This new PR has all of the changes from the previous one, plus the additional
nullhandling to ensure we don'f fail the activity when attempting to record metrics. This PR can wait to be merged until after the code freeze.