Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🐛 Fix custom connection creation endpoint #19702

Merged
merged 4 commits into from
Nov 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { AirbyteRequestService } from "core/request/AirbyteRequestService";

import {
createDestinationDefinition,
DestinationDefinitionCreate,
createCustomDestinationDefinition,
CustomDestinationDefinitionCreate,
DestinationDefinitionIdWithWorkspaceId,
DestinationDefinitionUpdate,
getDestinationDefinitionForWorkspace,
Expand All @@ -28,7 +28,7 @@ export class DestinationDefinitionService extends AirbyteRequestService {
return updateDestinationDefinition(body, this.requestOptions);
}

public create(body: DestinationDefinitionCreate) {
return createDestinationDefinition(body, this.requestOptions);
public createCustom(body: CustomDestinationDefinitionCreate) {
return createCustomDestinationDefinition(body, this.requestOptions);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import {
SourceDefinitionIdWithWorkspaceId,
updateSourceDefinition,
SourceDefinitionUpdate,
createSourceDefinition,
SourceDefinitionCreate,
CustomSourceDefinitionCreate,
createCustomSourceDefinition,
} from "../../request/AirbyteClient";

export class SourceDefinitionService extends AirbyteRequestService {
Expand All @@ -28,7 +28,7 @@ export class SourceDefinitionService extends AirbyteRequestService {
return updateSourceDefinition(body, this.requestOptions);
}

public create(body: SourceDefinitionCreate) {
return createSourceDefinition(body, this.requestOptions);
public createCustom(body: CustomSourceDefinitionCreate) {
return createCustomSourceDefinition(body, this.requestOptions);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { Button } from "components/ui/Button";
import { RoutePaths, DestinationPaths } from "pages/routePaths";
import { useCreateDestinationDefinition } from "services/connector/DestinationDefinitionService";
import { useCreateSourceDefinition } from "services/connector/SourceDefinitionService";
import { useCurrentWorkspaceId } from "services/workspaces/WorkspacesService";

import CreateConnectorModal from "./CreateConnectorModal";

Expand All @@ -25,6 +26,7 @@ interface ICreateProps {

const CreateConnector: React.FC<IProps> = ({ type }) => {
const navigate = useNavigate();
const workspaceId = useCurrentWorkspaceId();
const [isModalOpen, setIsModalOpen] = useState(false);
const [errorMessage, setErrorMessage] = useState("");
const onChangeModalState = () => {
Expand All @@ -45,7 +47,7 @@ const CreateConnector: React.FC<IProps> = ({ type }) => {

navigate(
{
pathname: `${RoutePaths.Source}${RoutePaths.SourceNew}`,
pathname: `/${RoutePaths.Workspaces}/${workspaceId}/${RoutePaths.Source}/${RoutePaths.SourceNew}`,
},
{ state: { sourceDefinitionId: result.sourceDefinitionId } }
);
Expand All @@ -61,7 +63,7 @@ const CreateConnector: React.FC<IProps> = ({ type }) => {

navigate(
{
pathname: `${RoutePaths.Destination}${DestinationPaths.NewDestination}`,
pathname: `/${RoutePaths.Workspaces}/${workspaceId}/${RoutePaths.Destination}/${DestinationPaths.NewDestination}`,
},
{ state: { destinationDefinitionId: result.destinationDefinitionId } }
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,10 @@ const useDestinationDefinition = <T extends string | undefined>(
const useCreateDestinationDefinition = () => {
const service = useGetDestinationDefinitionService();
const queryClient = useQueryClient();
const workspaceId = useCurrentWorkspaceId();

return useMutation<DestinationDefinitionRead, Error, DestinationDefinitionCreate>(
(destinationDefinition) => service.create(destinationDefinition),
(destinationDefinition) => service.createCustom({ workspaceId, destinationDefinition }),
{
onSuccess: (data) => {
queryClient.setQueryData(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ const useSourceDefinition = <T extends string | undefined>(
const useCreateSourceDefinition = () => {
const service = useGetSourceDefinitionService();
const queryClient = useQueryClient();
const workspaceId = useCurrentWorkspaceId();

return useMutation<SourceDefinitionRead, Error, SourceDefinitionCreate>(
(sourceDefinition) => service.create(sourceDefinition),
(sourceDefinition) => service.createCustom({ workspaceId, sourceDefinition }),
{
onSuccess: (data) => {
queryClient.setQueryData(
Expand Down