Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update date-time format instructions in docs #19707

Merged
merged 13 commits into from
Nov 28, 2022

Conversation

josephkmh
Copy link
Contributor

@josephkmh josephkmh commented Nov 22, 2022

What

While working on the datepicker component, I noticed several setup guides instruct users to input YYYY-MM-DD, but the actual connector form requires a full UTC datetime (YYYY-MM-DDTHH:mm:ssZ).

Example screenshots to illustrate:

source-freshdesk

Screenshot 2022-11-22 at 12 50 12 PM

source-chargebee

Screenshot 2022-11-22 at 2 26 12 PM

source-harvest

Screenshot 2022-11-22 at 2 36 52 PM

source-iterable

Screenshot 2022-11-22 at 2 42 22 PM

source-klaviyo

Screenshot 2022-11-22 at 2 45 23 PM

I also noticed that, for some reason, when "YYYY-MM-DDTHH:mm:ssZ" is written in a markdown ordered or unordered list, the end (":ssZ") is cut off. It seems to get interpreted as a line break:

image

Adding backticks around the expression fixes that:

image

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Nov 22, 2022
@josephkmh josephkmh marked this pull request as ready for review November 22, 2022 14:05
Copy link
Contributor

@sophia-wiley sophia-wiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants