Low-Code: added SessionTokenAuthenticator #19716

darynaishchenko · 2022-11-22T15:11:58Z

This auth method will be used in source-metabase #19236

girarda

girarda · 2022-11-22T22:48:27Z

airbyte-cdk/python/airbyte_cdk/sources/declarative/auth/token.py

@@ -115,3 +119,103 @@ def token(self) -> str:
        auth_string = f"{self._username.eval(self.config)}:{self._password.eval(self.config)}".encode("utf8")
        b64_encoded = base64.b64encode(auth_string).decode("utf8")
        return f"Basic {b64_encoded}"
+
+
+cacheSessionTokenAuthenticator = TTLCache(maxsize=1000, ttl=86400)


can you add a comment on how those values were chosen for posterity? Is it worth parameterizing them?

girarda · 2022-11-22T22:51:05Z

@darynaishchenko please run format on the files before merging because some files are not properly formatted

brianjlai

small adjustment on the version since its a new component feature, but otherwise looks good to me!

brianjlai · 2022-11-28T19:14:14Z

airbyte-cdk/python/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog

+## 0.9.6


Given that this is a net new feature, we should bump the minor version to 0.10.0

darynaishchenko · 2022-11-30T10:36:24Z

@girarda @brianjlai could you help me with it please. I'm doing this steps from README

Setup a virtual env:

python -m venv .venv
source .venv/bin/activate
pip install -e ".[dev]" # [dev] installs development-only dependencies
Iteration
Iterate on the code locally
Run tests via pytest -s unit_tests
Perform static type checks using mypy airbyte_cdk. MyPy configuration is in .mypy.ini.

But I get type checks errors in files which I didn't change. Is this ok, or I do something wrong?

girarda · 2022-12-07T03:58:45Z

@darynaishchenko what are the type check errors you're seeing?

darynaishchenko · 2022-12-07T13:54:25Z

@darynaishchenko please run format on the files before merging because some files are not properly formatted

done

darynaishchenko · 2022-12-07T13:55:17Z

@darynaishchenko what are the type check errors you're seeing?

It's not relevant, I fixed checks. thanks

girarda · 2022-12-08T23:13:39Z

airbyte-cdk/python/airbyte_cdk/sources/declarative/auth/token.py

+        if response.ok:
+            json_response = response.json()
+            self.logger.info(
+                f"Connection check for source successful for {json_response['common_name']} login at {json_response['last_login']}"


These two fields need to be configurable because the endpoints won't always return responses with "common_name" and "last_login" fields

alternatively, it would be fine not to log this much details here

girarda · 2022-12-08T23:18:24Z

airbyte-cdk/python/airbyte_cdk/sources/declarative/auth/token.py

+            username = self._username.eval(self.config)
+            password = self._password.eval(self.config)
+            session_token_response_key = self._session_token_response_key.eval(self.config)
+            api_url = f"{self._api_url.eval(self.config)}session"


the path will need to be configurable. This could be done by adding a field "login_url", which could be configured as
"session" in the case of metabase

girarda · 2022-12-08T23:21:04Z

airbyte-cdk/python/airbyte_cdk/sources/declarative/auth/token.py

+    def is_valid_session_token(self) -> bool:
+        try:
+            response = requests.get(
+                f"{self._api_url.eval(self.config)}user/current", headers={self.auth_header: self._session_token.eval(self.config)}


the path will need to be configurable. This could be done by adding a field "validate_session_url", which could be configured as
"/user/current" in the case of metabase

flash1293

It seems like the stylesheet changes are purely about whitespace, could you revert them?

darynaishchenko · 2022-12-12T10:16:06Z

It seems like the stylesheet changes are purely about whitespace, could you revert them?

thanks, fixed

girarda

this is great!

lazebnyi · 2022-12-12T20:29:31Z

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/3679536348
✅ https://github.com/airbytehq/airbyte/actions/runs/3679536348

lazebnyi · 2022-12-12T20:37:32Z

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/3679590977
✅ https://github.com/airbytehq/airbyte/actions/runs/3679590977

darynaishchenko requested review from girarda, artem1205 and roman-yermilov-gl November 22, 2022 15:11

darynaishchenko requested a review from a team as a code owner November 22, 2022 15:11

darynaishchenko self-assigned this Nov 22, 2022

octavia-squidington-iv added the CDK Connector Development Kit label Nov 22, 2022

girarda approved these changes Nov 22, 2022

View reviewed changes

darynaishchenko requested a review from girarda November 23, 2022 13:07

girarda requested a review from brianjlai November 28, 2022 18:14

brianjlai approved these changes Nov 29, 2022

View reviewed changes

darynaishchenko requested a review from brianjlai November 30, 2022 11:19

darynaishchenko force-pushed the daryna/airbyte-cdk-session-token-auth-for-low-code branch 2 times, most recently from 73f318a to 6505267 Compare November 30, 2022 13:58

darynaishchenko mentioned this pull request Dec 7, 2022

Source Metabase: migrate to Beta YAML #19236

Merged

girarda requested changes Dec 8, 2022

View reviewed changes

lazebnyi linked an issue Dec 9, 2022 that may be closed by this pull request

Low-Code: added SessionTokenAuthenticator #20297

Closed

darynaishchenko requested a review from a team as a code owner December 12, 2022 09:51

octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 12, 2022

flash1293 reviewed Dec 12, 2022

View reviewed changes

darynaishchenko added 4 commits December 12, 2022 12:11

added SessionTokenAuthenticator for low-code

fa2e8aa

added doc comments and formatted files

c13210d

fixed doc strings

4f3c260

added login_url and validate_session_url to config

6713da8

darynaishchenko force-pushed the daryna/airbyte-cdk-session-token-auth-for-low-code branch from 081815e to 6713da8 Compare December 12, 2022 10:14

octavia-squidington-iv removed area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 12, 2022

darynaishchenko requested review from flash1293 and girarda December 12, 2022 10:21

removed unused f-string, formatted

a4346c6

darynaishchenko force-pushed the daryna/airbyte-cdk-session-token-auth-for-low-code branch from 101302b to a4346c6 Compare December 12, 2022 10:45

girarda approved these changes Dec 12, 2022

View reviewed changes

lazebnyi added 2 commits December 12, 2022 21:17

Bump CDK version

41df33c

Update log

ccf1206

lazebnyi merged commit 2f306ea into master Dec 12, 2022

lazebnyi deleted the daryna/airbyte-cdk-session-token-auth-for-low-code branch December 12, 2022 20:45

github-actions bot mentioned this pull request Dec 13, 2022

Bump helm chart version reference to 0.43.3 #20408

Merged

octavia-squidington-iii mentioned this pull request Dec 18, 2022

Bump Airbyte version from 0.40.25 to 0.40.26 #20630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Low-Code: added SessionTokenAuthenticator #19716

Low-Code: added SessionTokenAuthenticator #19716

darynaishchenko commented Nov 22, 2022

girarda left a comment

girarda Nov 22, 2022

darynaishchenko Dec 7, 2022

girarda commented Nov 22, 2022

brianjlai left a comment

brianjlai Nov 28, 2022

darynaishchenko Dec 7, 2022

darynaishchenko commented Nov 30, 2022

girarda commented Dec 7, 2022

darynaishchenko commented Dec 7, 2022

darynaishchenko commented Dec 7, 2022

girarda Dec 8, 2022

girarda Dec 8, 2022

darynaishchenko Dec 12, 2022

girarda Dec 8, 2022

darynaishchenko Dec 12, 2022

girarda Dec 8, 2022

darynaishchenko Dec 12, 2022

flash1293 left a comment

darynaishchenko commented Dec 12, 2022

girarda left a comment

lazebnyi commented Dec 12, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Dec 12, 2022 •

edited by github-actions bot

Loading

Low-Code: added SessionTokenAuthenticator #19716

Low-Code: added SessionTokenAuthenticator #19716

Conversation

darynaishchenko commented Nov 22, 2022

girarda left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

girarda commented Nov 22, 2022

brianjlai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darynaishchenko commented Nov 30, 2022

girarda commented Dec 7, 2022

darynaishchenko commented Dec 7, 2022

darynaishchenko commented Dec 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

darynaishchenko commented Dec 12, 2022

girarda left a comment

Choose a reason for hiding this comment

lazebnyi commented Dec 12, 2022 • edited by github-actions bot Loading

lazebnyi commented Dec 12, 2022 • edited by github-actions bot Loading

lazebnyi commented Dec 12, 2022 •

edited by github-actions bot

Loading

lazebnyi commented Dec 12, 2022 •

edited by github-actions bot

Loading