-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable full SAT for the BigQuery source #19720
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
95ded5f
to
e8d7254
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
It would be very useful to store all links to the credentials and creation of test instances. |
/test connector=connectors/source-bigquery
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you commit the SQL files I would suggest documenting how you provisioned BigQuery with the test data. It's strange that the /test
reported status is "failing" while the tests have passed. I'm going to re-run it to check if it's a transient problem.
airbyte-integrations/connectors/source-bigquery/integration_tests/basic_dataset.sql
Show resolved
Hide resolved
airbyte-integrations/connectors/source-bigquery/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
/test connector=connectors/source-bigquery
Build PassedTest summary info:
|
@DoNotPanicUA would you mind trying to update your branch? I'm wondering if the Report status failure is due to recent changes on the AMI (cc @evantahler ) |
/test connector=connectors/source-bigquery
Build PassedTest summary info:
|
Yep! The AMI was fixed yesterday here #19949 for /test and /publish commands. Looking good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Please create a script or a README
under integration_tests
to explain how to run the sql
queries you committed.
airbyte-integrations/connectors/source-bigquery/acceptance-test-config.yml
Show resolved
Hide resolved
/test connector=connectors/source-bigquery
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes for the reasons explained here: #19915 (comment)
/test connector=connectors/source-bigquery
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated your branch to get the test working again. Feel free to merge once they pass.
/test connector=connectors/source-bigquery
Build PassedTest summary info:
|
What
Enable SAT for the BigQuery source
Added secrets:
Configured test instances
Found issues
SAT related issues:
Source related issues: