-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Amplitude: enable data region selection #19727
🎉 Source Amplitude: enable data region selection #19727
Conversation
Hello 👋, first thank you for this amazing contribution. We really appreciate the effort you've made to improve the project. If you have any questions feel free to send me a message in Slack! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
airbyte-integrations/connectors/source-amplitude/source_amplitude/api.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is room for improvement probably we can improve passing input params and limit them to just config
and pass only the config
to each stream class and parse it internally to look for different parts. However, this one looks good. LGTM!
|
||
@property | ||
def url_base(self) -> str: | ||
subdomain = "analytics.eu." if self.data_region == "EU Residency Server" else "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there more than EU + US?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No according to de documentation https://www.docs.developers.amplitude.com/analytics/apis/http-v2-api/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No according to the documentation https://www.docs.developers.amplitude.com/analytics/apis/http-v2-api/
/test connector=connectors/source-amplitude
Build FailedTest summary info:
|
/test connector=connectors/source-amplitude
Build PassedTest summary info:
|
/publish connector=connectors/source-amplitude
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Hey @mariamthiam @marcosmarxm - this PR introduced a breaking change that affected existing syncs. It looks like our test suite caught this breaking change, but it was muted. Even though the required field has a default, the default will not be set for configs that were created beforehand. This is leading to failed syncs upon upgrading the connector:
Could you please change this field to not be required and handle this being empty on the connector side? Thanks! |
What
Source Amplitude, enable data region selection describe in issue #19605
How
Add parameter
data_region
to make possible to select data server regionRecommended reading order
x.java
y.python
🚨 User Impact 🚨
No breaking changes, default value of region keep the same working method .
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.