-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low-code CDK: Update autogenerated docs #19786
Low-code CDK: Update autogenerated docs #19786
Conversation
Add commands to run integration tests using Docker, referencing https://airbytehq.github.io/connector-development/config-based/tutorial/testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scottleechua thanks for the improvement! Made one request for change and we should be good to go.
To run your integration tests with docker: | ||
``` | ||
docker build . -t airbyte/source-exchange-rates-tutorial:dev | ||
python -m pytest integration_tests -p integration_tests.acceptance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This runs integration tests using python - this should suggest using acceptance-tests-docker.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherifnada ah, thanks for that! Updated the command. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @scottleechua I'll merge tomorrow, I want to validate we don't need to regenerate any files.
@@ -35,7 +35,7 @@ check: | |||
- "customers" | |||
|
|||
spec: | |||
documentation_url: https://docsurl.com | |||
documentation_url: https://docs.airbyte.com/integrations/sources/{{dashCase name}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much! :D
What
Fixes issue #18658.
How
docs.airbyte.io
todocs.airbyte.com
🚨 User Impact 🚨
Minimal.
Pre-merge Checklist