Low-code CDK: Update autogenerated docs #19786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add commands to run integration tests using Docker, referencing https://airbytehq.github.io/connector-development/config-based/tutorial/testing
sherifnada
reviewed
Nov 24, 2022
There was a problem hiding this comment.
@scottleechua thanks for the improvement! Made one request for change and we should be good to go.
| To run your integration tests with docker: | ||
| ``` | ||
| docker build . -t airbyte/source-exchange-rates-tutorial:dev | ||
| python -m pytest integration_tests -p integration_tests.acceptance |
There was a problem hiding this comment.
This runs integration tests using python - this should suggest using acceptance-tests-docker.sh
There was a problem hiding this comment.
@sherifnada ah, thanks for that! Updated the command. 👍
marcosmarxm
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Thanks @scottleechua I'll merge tomorrow, I want to validate we don't need to regenerate any files.
| @@ -35,7 +35,7 @@ check: | |||
| - "customers" | |||
|
|
|||
| spec: | |||
| documentation_url: https://docsurl.com | |||
| documentation_url: https://docs.airbyte.com/integrations/sources/{{dashCase name}} | |||
sajarin
added
team/extensibility
area/low-code
type/enhancement
marcosmarxm
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes issue #18658.
How
docs.airbyte.iotodocs.airbyte.com🚨 User Impact 🚨
Minimal.
Pre-merge Checklist