Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize all connector icons #19840

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Optimize all connector icons #19840

merged 2 commits into from
Nov 29, 2022

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Nov 28, 2022

What

Puts all our SVG connector icons through svgo to optimize their size (e.g. remove unnecessary editor specific tags and attributes, etc.). This should not have any affect on the actual rendering of the icon.

@timroes timroes requested a review from a team November 28, 2022 18:22
@timroes timroes temporarily deployed to more-secrets November 28, 2022 18:23 Inactive
@timroes timroes temporarily deployed to more-secrets November 28, 2022 18:24 Inactive
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/server labels Nov 29, 2022
@timroes timroes temporarily deployed to more-secrets November 29, 2022 16:30 Inactive
@timroes timroes temporarily deployed to more-secrets November 29, 2022 16:30 Inactive
@timroes timroes merged commit b121ade into master Nov 29, 2022
@timroes timroes deleted the tim/svgo branch November 29, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants