Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resets for disabled connections #19864

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Conversation

alovew
Copy link
Contributor

@alovew alovew commented Nov 29, 2022

Resolves #19861

This is fixing a bug that was introduced during the connection form refactor. skipReset should be set to false if there is any change to the configured catalog, regardless of whether the connection is disabled.

@alovew alovew requested a review from a team as a code owner November 29, 2022 01:46
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 29, 2022
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a small linting fix so it builds. Code changes LGTM

@alovew
Copy link
Contributor Author

alovew commented Nov 29, 2022

Thank you!

@alovew alovew merged commit a970596 into master Nov 29, 2022
@alovew alovew deleted the anne/reset-disabled-conns branch November 29, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't skip reset when saving and resetting disabled connection
4 participants