-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-surveymonkey: fix getBaseURLByOrigin
#19868
Conversation
/test connector=connectors/source-surveymonkey
Build FailedTest summary info:
|
/test connector=connectors/source-surveymonkey
Build PassedTest summary info:
|
/publish connector=connectors/source-surveymonkey run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
getBaseURLByOrigin
getBaseURLByOrigin
What
The URL built to complete oauth flow seem wrong and return 404.
I suspect this URL to be badly formatted after this PR.
I think the
ACCESS_TOKEN_URL
is appended toAUTHORIZE_URL
, creating wrong URLs likehttps://api.surveymonkey.com/oauth/authorize/oauth/token
How
Remove the append of
AUTHORIZE_URL
ingetBaseURLByOrigin