Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-surveymonkey: fix getBaseURLByOrigin #19868

Merged
merged 6 commits into from
Nov 29, 2022

Conversation

alafanechere
Copy link
Contributor

What

The URL built to complete oauth flow seem wrong and return 404.
I suspect this URL to be badly formatted after this PR.
I think the ACCESS_TOKEN_URL is appended to AUTHORIZE_URL, creating wrong URLs like https://api.surveymonkey.com/oauth/authorize/oauth/token

How

Remove the append of AUTHORIZE_URL in getBaseURLByOrigin

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/surveymonkey labels Nov 29, 2022
@alafanechere
Copy link
Contributor Author

alafanechere commented Nov 29, 2022

/test connector=connectors/source-surveymonkey

🕑 connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/3572622489
❌ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/3572622489
🐛 https://gradle.com/s/4itap4uxsy63c

Build Failed

Test summary info:

Could not find result summary

@alafanechere alafanechere temporarily deployed to more-secrets November 29, 2022 09:14 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets November 29, 2022 09:14 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets November 29, 2022 09:43 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets November 29, 2022 09:43 Inactive
@alafanechere
Copy link
Contributor Author

alafanechere commented Nov 29, 2022

/test connector=connectors/source-surveymonkey

🕑 connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/3572883060
✅ connectors/source-surveymonkey https://github.com/airbytehq/airbyte/actions/runs/3572883060
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_surveymonkey/__init__.py       2      0   100%
source_surveymonkey/streams.py      131      7    95%
source_surveymonkey/source.py        69     13    81%
-----------------------------------------------------
TOTAL                               202     20    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

All Passed

@alafanechere alafanechere temporarily deployed to more-secrets November 29, 2022 09:48 Inactive
@alafanechere alafanechere temporarily deployed to more-secrets November 29, 2022 09:48 Inactive
@alafanechere
Copy link
Contributor Author

alafanechere commented Nov 29, 2022

/publish connector=connectors/source-surveymonkey run-tests=false

🕑 Publishing the following connectors:
connectors/source-surveymonkey
https://github.com/airbytehq/airbyte/actions/runs/3573251473


Connector Did it publish? Were definitions generated?
connectors/source-surveymonkey

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@alafanechere alafanechere changed the title source-surverymonkey: fix getBaseURLByOrigin source-surveymonkey: fix getBaseURLByOrigin Nov 29, 2022
@alafanechere alafanechere merged commit f262bef into master Nov 29, 2022
@alafanechere alafanechere deleted the augustin/source-surveymonkey/fix-oauth branch November 29, 2022 10:51
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets November 29, 2022 10:53 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets November 29, 2022 10:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/surveymonkey
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants