Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metric and attributes #19943

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Add metric and attributes #19943

merged 2 commits into from
Dec 1, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Improve visibility and monitoring capabilities for resets and syncs

How

  • Add metric to track reset requests for baseline monitoring
  • Add attributes to bytes/records synced

Recommended reading order

  1. ApmTraceUtils.java
  2. ReplicationActivityImpl.java

Tests

  • Added test to ApmTraceUtilsTest
  • All other existing tests pass
  • Project builds locally

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Nov 30, 2022
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 30, 2022 21:10 Inactive
@jdpgrailsdev jdpgrailsdev merged commit fb387fa into master Dec 1, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/more-instrumentation branch December 1, 2022 16:19
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Closed
This was referenced Dec 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

@gosusnp gosusnp Awaiting requested review from gosusnp

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdpgrailsdev @benmoriceau @octavia-squidington-iv