Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🧹 Move CatalogDiff modal from views to components #20024

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

edmundito
Copy link
Contributor

What

Related to #17155

Moves CatalogDiff modal from views/ to components/ to follow the new naming convention.

How

  • Moves the files
  • Removes components subfolder
  • Clean up imports
  • Moves hook to open modal to hooks/connection

@edmundito edmundito requested a review from a team as a code owner December 2, 2022 15:45
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 2, 2022
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, build would fail if anything was missed

@edmundito edmundito force-pushed the edmundito/move-catalogdiff branch from 97e10d8 to 05c6836 Compare December 5, 2022 19:01
@edmundito edmundito merged commit 779f275 into master Dec 6, 2022
@edmundito edmundito deleted the edmundito/move-catalogdiff branch December 6, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/platform-move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants