Add /v1/web_backend/check_updates #20041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/api
gosusnp
requested review from
benmoriceau,
alovew,
colesnodgrass and
jdpgrailsdev
jdpgrailsdev
reviewed
Dec 5, 2022
| .toList(); | ||
| } catch (final IOException e) { | ||
| log.error("Failed to get current list of standard destination definitions", e); | ||
| return 0; |
There was a problem hiding this comment.
Nit: consider extracting to a constant to avoid re-use/magic number.
jdpgrailsdev
approved these changes
Dec 5, 2022
with one small nit.
benmoriceau
approved these changes
Dec 5, 2022
airbyte-server/src/main/java/io/airbyte/server/handlers/WebBackendCheckUpdatesHandler.java
Show resolved
Hide resolved
| final static boolean INCLUDE_TOMBSTONE = false; | ||
|
|
||
| @BeforeEach | ||
| void beforeEach() { |
There was a problem hiding this comment.
Nit: this could be replace by the annotation @mock and @InjectMock
There was a problem hiding this comment.
Played with the annotations, I think a setup function feels clearer than having annotations on both members + class to figure out how the objects are initialized.
Might be related to the fact that I am not a big fan of the lombok type of annotations.
krishnaglick
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Relates to #19853
How