Add test for checking stream view #20073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizel852
requested changes
Dec 6, 2022
airbyte-webapp-e2e-tests/cypress/integration/connection.spec.ts
Outdated
Show resolved
Hide resolved
| @@ -9,6 +9,9 @@ const destinationNamespaceSource = "div[data-testid='namespaceDefinition-source' | |||
| const destinationNamespaceCustomInput = "input[data-testid='input']"; | |||
| const syncModeDropdown = "div[data-testid='syncSettingsDropdown'] input"; | |||
| const cursorFieldDropdown = "button[class^='PathPopoutButton_button']"; | |||
| const streamFieldNames = "[class^='TreeRowWrapper_rowWrapper'] span"; | |||
| const streamDataTypes = "[class^='TreeRowWrapper_rowWrapper'] div:nth-child(2)"; | |||
| const arrowStream = "[class^='Arrow_container__']"; | |||
There was a problem hiding this comment.
what is an arrow stream? 🙂
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, okay, can we rename it to ExpandStreamDetailsTableBtn please? 🙂
Co-authored-by: Vladimir <volodymyr.s.petrov@globallogic.com>
dizel852
requested changes
Dec 8, 2022
| @@ -9,6 +9,9 @@ const destinationNamespaceSource = "div[data-testid='namespaceDefinition-source' | |||
| const destinationNamespaceCustomInput = "input[data-testid='input']"; | |||
| const syncModeDropdown = "div[data-testid='syncSettingsDropdown'] input"; | |||
| const cursorFieldDropdown = "button[class^='PathPopoutButton_button']"; | |||
| const streamFieldNames = "[class^='TreeRowWrapper_rowWrapper'] span"; | |||
| const streamDataTypes = "[class^='TreeRowWrapper_rowWrapper'] div:nth-child(2)"; | |||
| const arrowStream = "[class^='Arrow_container__']"; | |||
There was a problem hiding this comment.
Oh, okay, can we rename it to ExpandStreamDetailsTableBtn please? 🙂
dizel852
approved these changes
Dec 8, 2022
edmundito
approved these changes
Dec 14, 2022
Comment on lines
+12
to
+13
| const streamFieldNames = "[class^='TreeRowWrapper_rowWrapper'] span"; | ||
| const streamDataTypes = "[class^='TreeRowWrapper_rowWrapper'] div:nth-child(2)"; |
There was a problem hiding this comment.
These selectors work for now, but ideally, we should try to use testIds instead because the implementation can always change and break this. For this PR, it's OK to leave because we also have the problem in other areas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scope of PR was added test for checking stream view (test case number c_19)
https://docs.google.com/spreadsheets/d/1OMKYYoTAFeCAk_ZXUlFmiKpfnt7x5edRGxRQB4XMyQM