Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable PMD rule to prevent == string comparisons #20080

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Enable PMD rule to prevent == string comparisons #20080

merged 1 commit into from
Dec 5, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Prevent string comparisons using ==.

How

  • Enable PMD rule to detect use of == to compare strings
  • Fix existing issues

Recommended reading order

  1. rules.xml

Tests

  • All tests pass
  • All PMD checks pass
  • Project builds locally (platform and base connectors)

cc: @mfsiega-airbyte @edgao

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/server labels Dec 5, 2022
@jdpgrailsdev jdpgrailsdev merged commit 201df24 into master Dec 5, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/prevent-equals-compare-strings branch December 5, 2022 17:54
This was referenced Dec 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesnodgrass colesnodgrass colesnodgrass approved these changes

@gosusnp gosusnp gosusnp approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/platform issues related to the platform area/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdpgrailsdev @colesnodgrass @gosusnp @benmoriceau @octavia-squidington-iv