Show http method in the connector builder test panel request tab #20109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the HTTP method (GET/PUT/etc..) of the outgoing request to the test panel request tab.
Fixes #19622.
How
HttpRequest
object in openapi.yaml to include anhttp_method
property, whose values can beGET
,POST
,PUT
, orPATCH
, per theairbyte-cdk
's list ofBODY_REQUEST_METHODS
for sources../gradlew :airbyte-connector-builder-server:generateOpenApiPythonServer
from theairbyte
repo._create_request_from_log_message
method to include thehttp_method
key from the request.Note: we are currently unable to enforce the
enum
type specified in theopenapi.yml
, due to an open issue withpython-fastapi
's handling of enums. This means that theoretically we could see methods not supported byairbyte-cdk
. It looks to me like openapi's default python generator does support enums, but switching our generator felt heavy handed for this simple change. We can revisit later if we start requiring more enums.Recommended reading order
🚨 User Impact 🚨
No breaking changes. When submitting a test
read
request, the user will now see the http method that was used along with other information about the request, in the "Request" tab.Pre-merge Checklist
Expand the relevant checklist and delete the others.
Tests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.