source-postgres:just throw a warning if a cursor column contains null value #20192

subodh1810 · 2022-12-07T16:48:38Z

Issue : https://github.com/airbytehq/oncall/issues/1159

… value

subodh1810 · 2022-12-07T16:48:58Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3640985122
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3640985122
🐛 https://gradle.com/s/irabazze3d6we

Build Failed

Test summary info:

Could not find result summary

github-actions · 2022-12-07T16:50:10Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

❌ Sources (25)

Connector	Version	Changelog	Publish
`source-alloydb`	`1.0.32`	❌ (changelog missing)	✅
`source-alloydb-strict-encrypt`	`1.0.32`	🔵 (ignored)	🔵 (ignored)
`source-bigquery`	`0.2.3`	✅	✅
`source-clickhouse`	`0.1.14`	✅	✅
`source-clickhouse-strict-encrypt`	`0.1.14`	🔵 (ignored)	🔵 (ignored)
`source-cockroachdb`	`0.1.18`	✅	✅
`source-cockroachdb-strict-encrypt`	`0.1.18`	🔵 (ignored)	🔵 (ignored)
`source-db2`	`0.1.16`	✅	✅
`source-db2-strict-encrypt`	`0.1.16`	🔵 (ignored)	🔵 (ignored)
`source-dynamodb`	`0.1.0`	✅	✅
`source-jdbc`	`0.3.5`	⚠ (doc not found)	⚠ (not in seed)
`source-mongodb-strict-encrypt`	`0.1.19`	🔵 (ignored)	🔵 (ignored)
`source-mongodb-v2`	`0.1.19`	✅	✅
`source-mssql`	`0.4.25`	✅	✅
`source-mssql-strict-encrypt`	`0.4.25`	🔵 (ignored)	🔵 (ignored)
`source-mysql`	`1.0.15`	✅	✅
`source-mysql-strict-encrypt`	`1.0.15`	🔵 (ignored)	🔵 (ignored)
`source-oracle`	`0.3.21`	✅	✅
`source-oracle-strict-encrypt`	`0.3.21`	🔵 (ignored)	🔵 (ignored)
`source-postgres`	`1.0.32`	✅	✅
`source-postgres-strict-encrypt`	`1.0.32`	🔵 (ignored)	🔵 (ignored)
`source-redshift`	`0.3.15`	✅	✅
`source-scaffold-java-jdbc`	`0.1.0`	⚠ (doc not found)	⚠ (not in seed)
`source-snowflake`	`0.1.26`	✅	✅
`source-tidb`	`0.2.1`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

rodireich · 2022-12-07T16:51:14Z

...elational-db/src/main/java/io/airbyte/integrations/source/relationaldb/AbstractDbSource.java

      }
    }

+    if (!tablesWithInvalidCursorToWarnAbout.isEmpty()) {
+      LOGGER.warn(InvalidCursorInfoUtil.getInvalidCursorConfigMessage(tablesWithInvalidCursor));


This is going to break tests

ahan! once I will figure out which tests are breaking I will ignore them and add a todo. Does that work?

Sure
It should be tableWithNullValueCursorShouldThrowException and createTableWithNullValueCursor in PostgresSourceTest

rodireich · 2022-12-07T17:15:11Z

How are we going to notice workspaces that have this issue?
The issue discussed on planning: for visibility, a warning won't be collected in sentry, right?

edgao

@rodireich cloud will throw the connector logs into gcp logs, so we can look for the warning message. e.g. https://airbytehq-team.slack.com/archives/C04DZ1KD6R4/p1670427949994619?thread_ts=1670427696.000979&cid=C04DZ1KD6R4

edgao · 2022-12-07T17:50:48Z

...elational-db/src/main/java/io/airbyte/integrations/source/relationaldb/AbstractDbSource.java

      }
    }

+    if (!tablesWithInvalidCursorToWarnAbout.isEmpty()) {
+      LOGGER.warn(InvalidCursorInfoUtil.getInvalidCursorConfigMessage(tablesWithInvalidCursor));


maybe worth adding an easily-queryable message

Suggested change

LOGGER.warn(InvalidCursorInfoUtil.getInvalidCursorConfigMessage(tablesWithInvalidCursor));

LOGGER.warn("source-postgres detected null cursor value " + InvalidCursorInfoUtil.getInvalidCursorConfigMessage(tablesWithInvalidCursor));

subodh1810 · 2022-12-08T15:34:09Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3649736216
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3649736216
🐛 https://gradle.com/s/3iajrob56hyrc

Build Failed

Test summary info:

Could not find result summary

edgao

pending test success

edgao · 2022-12-08T22:59:43Z

it looks like the tests are still failing even though they're @Ignore-ed? maybe easier to just comment them out :(

PostgresSourceTest > viewWithNullValueCursorShouldThrowException() FAILED
    java.lang.AssertionError: 
    Expecting actual not to be null
        at io.airbyte.integrations.source.***.PostgresSourceTest.viewWithNullValueCursorShouldThrowException(PostgresSourceTest.java:602)

PostgresSourceTest > tableWithNullValueCursorShouldThrowException() FAILED
    java.lang.AssertionError: 
    Expecting actual not to be null
        at io.airbyte.integrations.source.***.PostgresSourceTest.tableWithNullValueCursorShouldThrowException(PostgresSourceTest.java:560)

subodh1810 · 2022-12-09T10:22:39Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3656518534
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3656518534
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1599    332    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 33.26s ==================

subodh1810 · 2022-12-12T10:13:50Z

/publish connector=connectors/source-postgres-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3674758085

Connector	Did it publish?	Were definitions generated?
connectors/source-postgres-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

subodh1810 · 2022-12-12T10:14:03Z

/publish connector=connectors/source-postgres

🕑 Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/3674759974

Connector	Did it publish?	Were definitions generated?
connectors/source-postgres	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

subodh1810 · 2022-12-12T10:14:17Z

/publish connector=connectors/source-alloydb-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-alloydb-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3674761633

Connector	Did it publish?	Were definitions generated?
connectors/source-alloydb-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

subodh1810 · 2022-12-12T10:14:25Z

/publish connector=connectors/source-alloydb

🕑 Publishing the following connectors:
connectors/source-alloydb
https://github.com/airbytehq/airbyte/actions/runs/3674762992

Connector	Did it publish?	Were definitions generated?
connectors/source-alloydb	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

source-postgres:just throw a warning if a cursor column contains null…

d9474f6

… value

subodh1810 requested review from rodireich and edgao December 7, 2022 16:48

subodh1810 self-assigned this Dec 7, 2022

octavia-squidington-iv added connectors/source/relational-db area/connectors Connector related issues labels Dec 7, 2022

rodireich approved these changes Dec 7, 2022

View reviewed changes

rodireich reviewed Dec 7, 2022

View reviewed changes

rodireich self-requested a review December 7, 2022 16:51

bleonard added the team/db-dw-sources Backlog for Database and Data Warehouse Sources team label Dec 7, 2022

edgao reviewed Dec 7, 2022

View reviewed changes

ignore test + update review comment

9117ae8

subodh1810 requested a review from a team as a code owner December 8, 2022 15:33

subodh1810 requested a review from edgao December 8, 2022 15:34

octavia-squidington-iv added the connectors/source/postgres label Dec 8, 2022

subodh1810 temporarily deployed to more-secrets December 8, 2022 15:35 — with GitHub Actions Inactive

subodh1810 temporarily deployed to more-secrets December 8, 2022 15:36 — with GitHub Actions Inactive

edgao approved these changes Dec 8, 2022

View reviewed changes

rodireich approved these changes Dec 8, 2022

View reviewed changes

subodh1810 added 2 commits December 9, 2022 15:31

Merge branch 'master' into just_warn_postgres_null_value_cursor

5a66387

use Disabled annotation

3de4960

subodh1810 temporarily deployed to more-secrets December 9, 2022 10:18 — with GitHub Actions Inactive

subodh1810 temporarily deployed to more-secrets December 9, 2022 10:19 — with GitHub Actions Inactive

Merge branch 'master' into just_warn_postgres_null_value_cursor

a85d304

upgrade version

681a588

octavia-squidington-iv added area/documentation Improvements or additions to documentation connectors/source/postgres-strict-encrypt connectors/source/alloydb labels Dec 12, 2022

upgrade version for alloy db strict encrypt as well

444ace9

octavia-squidington-iv added the connectors/source/alloydb-strict-encrypt label Dec 12, 2022

subodh1810 temporarily deployed to more-secrets December 12, 2022 10:15 — with GitHub Actions Inactive

auto-bump connector version

5bf6c2d

octavia-squidington-iii temporarily deployed to more-secrets December 12, 2022 10:26 — with GitHub Actions Inactive

octavia-squidington-iii temporarily deployed to more-secrets December 12, 2022 10:27 — with GitHub Actions Inactive

update definitions

96b7e64

subodh1810 merged commit a3708eb into master Dec 12, 2022

subodh1810 deleted the just_warn_postgres_null_value_cursor branch December 12, 2022 11:09

subodh1810 temporarily deployed to more-secrets December 12, 2022 11:10 — with GitHub Actions Inactive

github-actions bot mentioned this pull request Dec 13, 2022

Bump helm chart version reference to 0.43.3 #20408

Merged

octavia-squidington-iii mentioned this pull request Dec 18, 2022

Bump Airbyte version from 0.40.25 to 0.40.26 #20630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

source-postgres:just throw a warning if a cursor column contains null value #20192

source-postgres:just throw a warning if a cursor column contains null value #20192

subodh1810 commented Dec 7, 2022

subodh1810 commented Dec 7, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Dec 7, 2022 •

edited

Loading

❌ Sources (25)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

rodireich Dec 7, 2022

subodh1810 Dec 7, 2022

rodireich Dec 7, 2022

rodireich commented Dec 7, 2022

edgao left a comment

edgao Dec 7, 2022

subodh1810 commented Dec 8, 2022 •

edited by github-actions bot

Loading

edgao left a comment

edgao commented Dec 8, 2022

subodh1810 commented Dec 9, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Dec 12, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Dec 12, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Dec 12, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Dec 12, 2022 •

edited by github-actions bot

Loading

	LOGGER.warn(InvalidCursorInfoUtil.getInvalidCursorConfigMessage(tablesWithInvalidCursor));
	LOGGER.warn("source-postgres detected null cursor value " + InvalidCursorInfoUtil.getInvalidCursorConfigMessage(tablesWithInvalidCursor));

source-postgres:just throw a warning if a cursor column contains null value #20192

source-postgres:just throw a warning if a cursor column contains null value #20192

Conversation

subodh1810 commented Dec 7, 2022

subodh1810 commented Dec 7, 2022 • edited by github-actions bot Loading

Build Failed

github-actions bot commented Dec 7, 2022 • edited Loading

Affected Connector Report

❌ Sources (25)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

rodireich Dec 7, 2022

Choose a reason for hiding this comment

subodh1810 Dec 7, 2022

Choose a reason for hiding this comment

rodireich Dec 7, 2022

Choose a reason for hiding this comment

rodireich commented Dec 7, 2022

edgao left a comment

Choose a reason for hiding this comment

edgao Dec 7, 2022

Choose a reason for hiding this comment

subodh1810 commented Dec 8, 2022 • edited by github-actions bot Loading

Build Failed

edgao left a comment

Choose a reason for hiding this comment

edgao commented Dec 8, 2022

subodh1810 commented Dec 9, 2022 • edited by github-actions bot Loading

Build Passed

subodh1810 commented Dec 12, 2022 • edited by github-actions bot Loading

subodh1810 commented Dec 12, 2022 • edited by github-actions bot Loading

subodh1810 commented Dec 12, 2022 • edited by github-actions bot Loading

subodh1810 commented Dec 12, 2022 • edited by github-actions bot Loading

subodh1810 commented Dec 7, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Dec 7, 2022 •

edited

Loading

subodh1810 commented Dec 8, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Dec 9, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Dec 12, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Dec 12, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Dec 12, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Dec 12, 2022 •

edited by github-actions bot

Loading