-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-server: set tags on span in OAuthHandler
#20229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
issues related to the platform
area/server
labels
Dec 8, 2022
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 15:13
— with
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 15:13
— with
GitHub Actions
Inactive
jdpgrailsdev
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pedroslopez
requested changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
airbyte-server/src/main/java/io/airbyte/server/handlers/OAuthHandler.java
Outdated
Show resolved
Hide resolved
pedroslopez
approved these changes
Dec 8, 2022
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 16:13
— with
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 16:14
— with
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 16:30
— with
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 16:30
— with
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 17:17
— with
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 17:17
— with
GitHub Actions
Inactive
…/airbyte into augustin/server/more-span-tags
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 19:31
— with
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 19:31
— with
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 19:51
— with
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
December 8, 2022 19:51
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes https://github.com/airbytehq/airbyte-cloud/issues/3672
To track OAuth errors per connector, we must enrich our traces with new tags.
How
Add tags to traces in the following methods of
OAuthHandler
:getSourceOAuthConsent
getDestinationOAuthConsent
completeSourceOAuth
completeDestinationOAuth