Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-server: set tags on span in OAuthHandler #20229

Merged
merged 8 commits into from
Dec 8, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Dec 8, 2022

What

Closes https://github.com/airbytehq/airbyte-cloud/issues/3672
To track OAuth errors per connector, we must enrich our traces with new tags.

How

Add tags to traces in the following methods of OAuthHandler:

  • getSourceOAuthConsent
  • getDestinationOAuthConsent
  • completeSourceOAuth
  • completeDestinationOAuth

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/server labels Dec 8, 2022
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 15:13 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 15:13 — with GitHub Actions Inactive
@alafanechere alafanechere marked this pull request as ready for review December 8, 2022 15:28
@alafanechere alafanechere requested review from jdpgrailsdev and a team December 8, 2022 15:28
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 16:13 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 16:14 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 16:30 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 16:30 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 17:17 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 17:17 — with GitHub Actions Inactive
@alafanechere alafanechere requested a review from a team as a code owner December 8, 2022 19:29
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 19:31 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 19:31 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 19:51 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 8, 2022 19:51 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants