-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Pinterest: added TypeTransformer to keep the schemas safe #20242
Conversation
/test connector=connectors/source-pinterest
Build FailedTest summary info:
|
/test connector=connectors/source-pinterest
Build FailedTest summary info:
|
/test connector=connectors/source-pinterest
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Need small improvement.
airbyte-integrations/connectors/source-pinterest/source_pinterest/source.py
Outdated
Show resolved
Hide resolved
/publish connector=connectors/source-pinterest
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…sion
What
According to the SAT test: https://github.com/airbytehq/airbyte/actions/runs/3638303982, the
campaign_analytics
stream producesAD_ACCOUNT
field asint
, butstring
was required, based on the schema.How
🚨 User Impact 🚨
No impact is expected.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here