Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More destination fixes for ci_check_dependency #20274

Merged
merged 1 commit into from
Dec 9, 2022
+8 −5
Merged

More destination fixes for ci_check_dependency #20274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...grations/destinations/azureblobstorage.md → ...ations/destinations/azure-blob-storage.md
View file
Open in desktop
File renamed without changes.
2 changes: 2 additions & 0 deletions docs/integrations/destinations/redpanda.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ More info about this can be found in the [Redpanda producer configs documentatio

_NOTE_: Configurations for SSL are not available yet.

## CHANGELOG

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :------------- |
| 0.1.0 | 2022-08-05 | [18884](https://github.com/airbytehq/airbyte/pull/18884) | Initial commit |
11 changes: 6 additions & 5 deletions tools/bin/ci_check_dependency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,14 @@ def get_connector_version_status(connector, version):


def get_connector_changelog_status(connector: str, version) -> str:
type, name = connector.replace("-strict-encrypt", "").split("-", 1)
type, name = connector.replace("-strict-encrypt", "").replace("-denormalized", "").split("-", 1)
doc_path = f"{DOC_PATH}{type}s/{name}.md"

if any(regex.match(connector) for regex in IGNORED_DESTINATIONS):
return "🔵<br/>(ignored)"
if not os.path.exists(doc_path):
return "⚠<br/>(doc not found)"

with open(doc_path) as f:
after_changelog = False
for line in f:
Expand All @@ -139,10 +143,7 @@ def get_connector_changelog_status(connector: str, version) -> str:
if after_changelog and version in line:
return "✅"

if any(regex.match(connector) for regex in IGNORED_DESTINATIONS):
return "🔵<br/>(ignored)"
else:
return "❌<br/>(changelog missing)"
return "❌<br/>(changelog missing)"


def as_bulleted_markdown_list(items):
Expand Down