Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update connector oneOf descriptions #20378

Merged
merged 26 commits into from
Dec 15, 2022
Merged

Update connector oneOf descriptions #20378

merged 26 commits into from
Dec 15, 2022

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Dec 12, 2022 •
edited
Loading

What

Related to #19983

Updates the specs to use the new ability of listing options in the tooltip - right now the places specs changed in this PR have the options listed in the description of the oneOf property itself, which means it's showing twice now.

This PR moves these descriptions into the individual options instead.

@flash1293 flash1293 changed the title Update connector one of descriptions Update connector oneOf descriptions Dec 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022 •
edited
Loading

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (5)
Connector Version Changelog Publish
source-alloydb 1.0.34 ✅ ✅
source-alloydb-strict-encrypt 1.0.34 🔵
(ignored)		 🔵
(ignored)
source-mysql 1.0.18 ✅ ✅
source-mysql-strict-encrypt 1.0.18 🔵
(ignored)		 🔵
(ignored)
source-postgres-strict-encrypt 1.0.34 🔵
(ignored)		 🔵
(ignored)
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)
Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)
Category Status Actionable Item
Version ❌
mismatch		 The version of the connector is different from its normal variant. Please bump the version of the connector.
⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog ⚠
doc not found		 The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
❌
changelog missing		 There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish ⚠
not in seed		 The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
❌
diff seed version		 The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@flash1293 flash1293 mentioned this pull request Dec 12, 2022
Closed
37 tasks
@flash1293 flash1293 temporarily deployed to more-secrets December 12, 2022 17:46 — with GitHub Actions Inactive
@flash1293 flash1293 temporarily deployed to more-secrets December 12, 2022 17:46 — with GitHub Actions Inactive
@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Dec 12, 2022
@flash1293 flash1293 temporarily deployed to more-secrets December 12, 2022 17:54 — with GitHub Actions Inactive
@flash1293 flash1293 temporarily deployed to more-secrets December 12, 2022 17:54 — with GitHub Actions Inactive
@flash1293 flash1293 temporarily deployed to more-secrets December 12, 2022 17:56 — with GitHub Actions Inactive
@flash1293 flash1293 temporarily deployed to more-secrets December 12, 2022 17:56 — with GitHub Actions Inactive
@flash1293 flash1293 temporarily deployed to more-secrets December 14, 2022 13:05 — with GitHub Actions Inactive
@flash1293 flash1293 temporarily deployed to more-secrets December 14, 2022 13:05 — with GitHub Actions Inactive
@flash1293 flash1293 temporarily deployed to more-secrets December 14, 2022 14:55 — with GitHub Actions Inactive
@flash1293 flash1293 temporarily deployed to more-secrets December 14, 2022 14:56 — with GitHub Actions Inactive
@flash1293
Copy link
Contributor Author

flash1293 commented Dec 14, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mysql

🕑 Publishing the following connectors:
connectors/source-mysql
https://github.com/airbytehq/airbyte/actions/runs/3696035084


Connector Did it publish? Were definitions generated?
connectors/source-mysql ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 14, 2022 17:41 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 14, 2022 17:42 — with GitHub Actions Inactive
@flash1293
Copy link
Contributor Author

flash1293 commented Dec 14, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mysql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mysql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3697485748


Connector Did it publish? Were definitions generated?
connectors/source-mysql-strict-encrypt ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@flash1293
Copy link
Contributor Author

flash1293 commented Dec 14, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres

🕑 Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/3697731811


Connector Did it publish? Were definitions generated?
connectors/source-postgres ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@flash1293
Copy link
Contributor Author

flash1293 commented Dec 14, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3697977827


Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@flash1293
Copy link
Contributor Author

flash1293 commented Dec 14, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-alloydb

🕑 Publishing the following connectors:
connectors/source-alloydb
https://github.com/airbytehq/airbyte/actions/runs/3697981661


Connector Did it publish? Were definitions generated?
connectors/source-alloydb ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@flash1293
Copy link
Contributor Author

flash1293 commented Dec 14, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-alloydb-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-alloydb-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3697981546


Connector Did it publish? Were definitions generated?
connectors/source-alloydb-strict-encrypt ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 14, 2022 19:24 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 14, 2022 19:25 — with GitHub Actions Inactive
@subodh1810 subodh1810 temporarily deployed to more-secrets December 15, 2022 10:16 — with GitHub Actions Inactive
@subodh1810 subodh1810 temporarily deployed to more-secrets December 15, 2022 10:16 — with GitHub Actions Inactive
@flash1293
Copy link
Contributor Author

Merging as discussed with @subodh1810

@flash1293 flash1293 merged commit b8724c2 into master Dec 15, 2022
@flash1293 flash1293 deleted the flash1293/update-connector-oneOf-descriptions branch December 15, 2022 11:25
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grishick grishick grishick approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/postgres connectors/destination/postgres-strict-encrypt connectors/destination/redis connectors/source/alloydb connectors/source/alloydb-strict-encrypt connectors/source/mysql connectors/source/mysql-strict-encrypt connectors/source/postgres connectors/source/postgres-strict-encrypt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flash1293 @grishick @subodh1810 @octavia-squidington-iii @octavia-squidington-iv