Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Twilio: fix failed SAT and exposed auth_token #20430

Merged
merged 8 commits into from
Dec 14, 2022

Conversation

bazarnov
Copy link
Collaborator

What

Based on: https://github.com/Hadryan/airbyte/blob/b691841773e6e02802c1b5b86e20c6d0bdcb187b/airbyte-integrations/connectors/source-twilio/integration_tests/expected_records.txt#L527
The auth_token field contains the sensitive info, that should not be exposed while testing the connector.

How

  • adjusted SAT to avoid checking this field
  • faked the value of the field to hide the secrets, inside expected_records

@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 13, 2022

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3688770436
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3688770436
🐛 https://gradle.com/s/iu4ltfvl4qtuk

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: All ...
================== 1 failed, 33 passed in 1706.85s (0:28:26) ===================

@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 13, 2022

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3690315178
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3690315178
🐛 https://gradle.com/s/7ecl2zbzfxx2a

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream keys:...
================== 1 failed, 33 passed in 1491.91s (0:24:51) ===================

@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 14, 2022

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3694228771
❌ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3694228771
🐛 https://gradle.com/s/53ogxfyii5cts

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream accou...
================== 1 failed, 33 passed in 1323.53s (0:22:03) ===================

@bazarnov
Copy link
Collaborator Author

bazarnov commented Dec 14, 2022

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3698255867
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/3698255867
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_twilio/auth.py           8      0   100%
source_twilio/__init__.py       2      0   100%
source_twilio/source.py        28      2    93%
source_twilio/streams.py      279     21    92%
-----------------------------------------------
TOTAL                         317     23    93%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1599    332    79%

Build Passed

Test summary info:

All Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants