Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-connector-ops: typo in thruthfulness evaluation #20470

Merged
merged 4 commits into from
Dec 14, 2022
Merged

ci-connector-ops: typo in thruthfulness evaluation #20470

merged 4 commits into from
Dec 14, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Dec 14, 2022 •
edited
Loading

What

There was a typo in the truthfulness evaluation that conditionally runs the action to check if the required reviewers reviewed the PR.

How

Quoting the boolean fixes it.

@alafanechere alafanechere marked this pull request as ready for review December 14, 2022 08:55
@alafanechere alafanechere temporarily deployed to more-secrets December 14, 2022 09:30 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 14, 2022 09:31 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 14, 2022 09:45 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 14, 2022 09:46 — with GitHub Actions Inactive
@octavia-squidington-iv octavia-squidington-iv removed the area/connectors Connector related issues label Dec 14, 2022
@alafanechere alafanechere temporarily deployed to more-secrets December 14, 2022 09:49 — with GitHub Actions Inactive
@alafanechere alafanechere changed the title test: do not merge ci-connector-ops: typo in thruthfulness evaluation Dec 14, 2022
@alafanechere alafanechere temporarily deployed to more-secrets December 14, 2022 09:50 — with GitHub Actions Inactive
@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="typo in truthfulness evaluation in a GitHub workflow"

@octavia-approvington
Copy link
Contributor

After a careful ML study,
we think this looks okay.
imagine code being okay

@octavia-approvington octavia-approvington merged commit cdb26cd into master Dec 14, 2022
@octavia-approvington octavia-approvington deleted the augustin/test/review-check branch December 14, 2022 09:53
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alafanechere @octavia-approvington @octavia-squidington-iv