[ISSUE #20044] generate pydantic models from handwritten schema #20475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ApiKeyAuthenticator - BasicHttpAuthenticator - BearerAuthenticator - DeclarativeOauth2Authenticator - NoAuth
…on 'type' not being defined)
…rm validation against the handwritten schema
maxi297
commented
Dec 14, 2022
brianjlai
approved these changes
Dec 14, 2022
maxi297
force-pushed
the
issue-20044_generate-pydantic-models-from-handwritten-schema
branch
from
ddf2d94
to
4471266
Compare
|
My bad for triggering the source acceptance test on this PR. It should have been on 20599 |
Base automatically changed from
low_code_handwritten_component_schema
to
master
December 19, 2022 20:42
…handwritten-schema
|
/approve-and-merge reason="This is tooling improvement that has no impact on the airbyte-cdk itself but will help our development team to iterate through the low-code project" |
|
What are we doing again? |
octavia-approvington
approved these changes
Dec 20, 2022
octavia-approvington
deleted the
issue-20044_generate-pydantic-models-from-handwritten-schema
branch
|
Squash and merge |
This was referenced Jan 6, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR addressed this ticket. It will allow for automatic model generation based on the handwritten component manifest.
How
The generations follows the same life-cycle as the generation of the Airbyte protocol files i.e.:
Manually
Run
./gradlew generateComponentManifestClassFilesAutomatically (as part of GitHub "Connectors Base" check)
When the check runs:
Note that
airbyte-cdk/python/airbyte_cdk/sources/declarative/models/__init__.pyhas been excluded from flake8 because it generated error F401 and F403.Recommended reading order
airbyte-cdk/python/airbyte_cdk/sources/declarative/models/low_code_component_schema.pyhas been autogenerated and the validation on the generation is part of issue #19759🚨 User Impact 🚨
None yet. Eventually, we will use the generated model in the factory that generates our Python objects but this is for a later issue