Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-mongodb-v2: enable SAT #20484

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Dec 14, 2022

What

Closes #19897
Enable SAT on source-mongodb-v2

How

  • Use the sample-airbnb database existing on our mongo db instance
  • Create a valid configuration structure for SAT in GSM
  • Enable discovery, connection, basic_read and full_refresh tests.
  • Set custom timeouts, as some operations on this connector are very long...

#N.B.
The credentials used for java acceptance test (which are also running on /test) have a different structure than the connector configuration. I did not try to align the java credentials structure to the connector configuration as this is out of the scope of this story. I created a second GSM secret for SAT. We have two GSM secrets for this connector: one for SAT, one for Java acceptance tests

@octavia-squidington-iv octavia-squidington-iv added the area/connectors Connector related issues label Dec 14, 2022
@alafanechere
Copy link
Contributor Author

alafanechere commented Dec 14, 2022

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/3696743386
❌ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/3696743386
🐛 https://gradle.com/s/gv7u77wseqo7a

Build Failed

Test summary info:

Could not find result summary

@alafanechere
Copy link
Contributor Author

alafanechere commented Dec 15, 2022

/test connector=connectors/source-mongodb-v2

🕑 connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/3702971676
✅ connectors/source-mongodb-v2 https://github.com/airbytehq/airbyte/actions/runs/3702971676
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1599    332    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================== 27 passed, 1 skipped in 136.21s (0:02:16) ===================

@alafanechere alafanechere requested a review from a team December 15, 2022 10:46
@alafanechere alafanechere marked this pull request as ready for review December 15, 2022 10:46
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Tests are green, so 👍 from me!

@evantahler evantahler requested a review from a team December 15, 2022 18:53
@alafanechere alafanechere merged commit 061e269 into master Dec 15, 2022
@alafanechere alafanechere deleted the augustin/source-mongodb-v2/enable-sat branch December 15, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable SAT for hosted sources - mongodb-v2
3 participants