Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK 0.15.0 and source-github 0.3.10 -- revert AvailabillityStrategy changes #20523

Merged
merged 8 commits into from
Dec 15, 2022

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Dec 15, 2022

What

  • New 0.15.0 release of the CDK that reverts changes added in 0.13.0 and 0.13.3
  • New version of github 0.3.10 that reverts changes from 0.3.9 (should functionally be the same as 0.3.8)

Why

We ran into issues especially with substreams interacting with these changes, maybe also API errors that are not strictly HTTPErrors. (Not quite sure, will update this when we've tracked down the issue). Connectors that have CDK versions 0.13.x and 0.14.x installed might run into these issues. We publish a new CDK version so we can build those connectors with 0.15.0.

We publish a new github version with reverted changes so that we can unpin 0.3.8 in the source definition mask on cloud.

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/github labels Dec 15, 2022
@erohmensing erohmensing temporarily deployed to more-secrets December 15, 2022 17:00 — with GitHub Actions Inactive
@erohmensing erohmensing temporarily deployed to more-secrets December 15, 2022 17:01 — with GitHub Actions Inactive
@octavia-squidington-iv octavia-squidington-iv removed the area/documentation Improvements or additions to documentation label Dec 15, 2022
@erohmensing erohmensing temporarily deployed to more-secrets December 15, 2022 17:06 — with GitHub Actions Inactive
@erohmensing erohmensing temporarily deployed to more-secrets December 15, 2022 17:07 — with GitHub Actions Inactive
@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Dec 15, 2022
@erohmensing erohmensing marked this pull request as ready for review December 15, 2022 17:16
@erohmensing erohmensing requested a review from a team as a code owner December 15, 2022 17:16
@erohmensing erohmensing temporarily deployed to more-secrets December 15, 2022 17:17 — with GitHub Actions Inactive
@erohmensing erohmensing temporarily deployed to more-secrets December 15, 2022 17:17 — with GitHub Actions Inactive
@erohmensing erohmensing changed the title Ella/cdk revert CDK 0.15.0 and source-github 0.3.10 -- revert AvailabillityStrategy changes Dec 15, 2022
@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

/publish-cdk dry-run=true

https://github.com/airbytehq/airbyte/actions/runs/3706431574

Comment on lines 61 to 66
"cachetools",
],
python_requires=">=3.9",
extras_require={
"dev": [
"freezegun",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were removed accidentally - they were part of the commits that shouldn't have been reverted. Need to be added back in like the changelog. This was a merge conflict resolution issue. Adding them back in!

@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

/publish-cdk dry-run=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/3706547595
https://github.com/airbytehq/airbyte/actions/runs/3706547595

@erohmensing erohmensing temporarily deployed to more-secrets December 15, 2022 17:41 — with GitHub Actions Inactive
@erohmensing erohmensing temporarily deployed to more-secrets December 15, 2022 17:42 — with GitHub Actions Inactive
@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

/publish-cdk dry-run=false

🕑 https://github.com/airbytehq/airbyte/actions/runs/3706614474
https://github.com/airbytehq/airbyte/actions/runs/3706614474

@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3706700669
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/3706700669
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/utils.py              14      0   100%
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/graphql.py           145      1    99%
source_github/streams.py           796     44    94%
source_github/source.py            104     27    74%
----------------------------------------------------
TOTAL                             9868     72    99%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============ 38 passed, 3 skipped, 31 warnings in 331.94s (0:05:31) ============

@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

/publish connector=connectors/source-github

🕑 Publishing the following connectors:
connectors/source-github
https://github.com/airbytehq/airbyte/actions/runs/3706841873


Connector Did it publish? Were definitions generated?
connectors/source-github

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 15, 2022 18:48 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 15, 2022 18:49 — with GitHub Actions Inactive
@erohmensing erohmensing merged commit 8bb4128 into master Dec 15, 2022
@erohmensing erohmensing deleted the ella/cdk-revert branch December 15, 2022 19:24
erohmensing added a commit that referenced this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants