Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airbyte-workers copyGeneratedTar depends on generateWellKnownTypes #20528

Merged
merged 1 commit into from
Dec 15, 2022
Merged

airbyte-workers copyGeneratedTar depends on generateWellKnownTypes #20528

merged 1 commit into from
Dec 15, 2022

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Dec 15, 2022 •
edited
Loading

fix for https://github.com/airbytehq/airbyte/actions/runs/3705267099/jobs/6279243380#step:7:366

specifically https://github.com/airbytehq/airbyte/actions/runs/3705267099/workflow#L147 - this is where we invoke copyGenerateTar, as preparation for a docker buildx bake

in my continued adventures to add a single file to a docker image 😓

@edgao edgao requested a review from a team as a code owner December 15, 2022 17:51
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Dec 15, 2022
@edgao edgao temporarily deployed to more-secrets December 15, 2022 17:52 — with GitHub Actions Inactive
@edgao edgao temporarily deployed to more-secrets December 15, 2022 17:52 — with GitHub Actions Inactive
supertopher
supertopher approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me Ed. Good luck on the quest!

@edgao edgao mentioned this pull request Dec 15, 2022
Closed
@edgao edgao changed the title airbyte-workers copyGenerateTar depends on generateWellKnownTypes airbyte-workers copyGeneratedTar depends on generateWellKnownTypes Dec 15, 2022
@edgao edgao merged commit 69bc4a3 into master Dec 15, 2022
@edgao edgao deleted the edgao/worker_docker_dependency branch December 15, 2022 18:41
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supertopher supertopher supertopher approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgao @supertopher @octavia-squidington-iv