Source AlphaVantage - add quote stream to alpha-vantage #20564

sajarin · 2022-12-16T11:16:42Z

What

Adds quotes stream to Alpha Vantage

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

sajarin · 2022-12-16T12:10:29Z

/test connector=connectors/source-alpha-vantage

🕑 connectors/source-alpha-vantage https://github.com/airbytehq/airbyte/actions/runs/3712969056
✅ connectors/source-alpha-vantage https://github.com/airbytehq/airbyte/actions/runs/3712969056
Python tests coverage:

Name                                             Stmts   Miss  Cover
--------------------------------------------------------------------
source_alpha_vantage/__init__.py                     2      0   100%
source_alpha_vantage/object_dpath_extractor.py      31      2    94%
source_alpha_vantage/source.py                       4      1    75%
--------------------------------------------------------------------
TOTAL                                               37      3    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
================= 27 passed, 2 skipped, 29 warnings in 35.56s ==================

geekwhocodes · 2022-12-16T16:32:16Z

@sajarin I can review this PR.

geekwhocodes

@sajarin Can we update the correct order value for the fields in spec.yaml

airbyte/airbyte-integrations/connectors/source-alpha-vantage/source_alpha_vantage/spec.yaml

Line 43 in 3b6c9d8

order: 4

Also, is there a reason behind installing everything in editable mode in
https://github.com/airbytehq/airbyte/blob/3b6c9d8a569ffdb3d775306030c07504280eb807/airbyte-integrations/connectors/source-alpha-vantage/requirements.txt

Can you share screenshot of acceptance tests?

sajarin · 2022-12-16T18:34:19Z

@geekwhocodes spec.yaml has been updated. Test are passing from the CI above. Can I get your approval or do you feel like there are still changes to be made?

geekwhocodes

LGTM :)

marcosmarxm · 2022-12-20T19:53:21Z

Hello 👋:skin-tone-2: and thank you for your contribution!

Airbyte has instituted a code freeze between 19 and 30 December, to make sure there are no disruptions during the holidays.
Because of this, reviewing and merging your contribution may take longer than usual.
We apologize for the delay, but we want everyone to have a quiet and happy holiday.

If you have any questions or need further clarification, please don't hesitate to ping via Slack.

sajarin · 2023-01-05T16:12:39Z

/test connector=connectors/source-alpha-vantage

🕑 connectors/source-alpha-vantage https://github.com/airbytehq/airbyte/actions/runs/3848396103
✅ connectors/source-alpha-vantage https://github.com/airbytehq/airbyte/actions/runs/3848396103
Python tests coverage:

Name                                             Stmts   Miss  Cover
--------------------------------------------------------------------
source_alpha_vantage/__init__.py                     2      0   100%
source_alpha_vantage/object_dpath_extractor.py      31      2    94%
source_alpha_vantage/source.py                       4      1    75%
--------------------------------------------------------------------
TOTAL                                               37      3    92%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 28 passed, 1 skipped, 29 warnings in 42.88s ==================

sajarin · 2023-01-05T16:26:50Z

/publish connector=connectors/source-alpha-vantage run-tests=false

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

sajarin · 2023-01-05T16:48:26Z

/publish connector=connectors/source-alpha-vantage run-tests=false

🕑 Publishing the following connectors:
connectors/source-alpha-vantage
https://github.com/airbytehq/airbyte/actions/runs/3848655640

Connector	Did it publish?	Were definitions generated?
connectors/source-alpha-vantage	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

feat: add quote stream to alpha-vantage

4923256

sajarin added area/connectors Connector related issues community bounty bounty-M Maintainer program: claimable medium bounty PR connectors/source/alpha-vantage labels Dec 16, 2022

Merge branch 'master' into alpha-vantage-quote

3b6c9d8

sajarin assigned geekwhocodes Dec 16, 2022

Merge branch 'master' into alpha-vantage-quote

947a19c

geekwhocodes suggested changes Dec 16, 2022

View reviewed changes

sajarin added 3 commits December 16, 2022 13:30

Merge branch 'master' into alpha-vantage-quote

0a6570d

updated spec.yaml with correct order values

4fbbf1a

Merge branch 'master' into alpha-vantage-quote

fe32087

docs: updated docs

ee0c2a7

octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Dec 16, 2022

geekwhocodes approved these changes Dec 16, 2022

View reviewed changes

Merge branch 'master' into alpha-vantage-quote

eb02b96

sajarin requested a review from marcosmarxm December 19, 2022 10:01

Merge branch 'master' into alpha-vantage-quote

db2543e

sajarin added 2 commits January 5, 2023 11:26

Merge branch 'master' into alpha-vantage-quote

45e845f

Merge branch 'master' into alpha-vantage-quote

adc78df

auto-bump connector version

ba9adc5

octavia-squidington-iii temporarily deployed to more-secrets January 5, 2023 17:03 — with GitHub Actions Inactive

sajarin merged commit 1da4abb into master Jan 5, 2023

sajarin deleted the alpha-vantage-quote branch January 5, 2023 17:21

This was referenced Jan 6, 2023

Bump Airbyte version from 0.40.26 to 0.40.27 #21092

Closed

Bump Airbyte version from 0.40.26 to 0.40.27 #21121

Closed

github-actions bot mentioned this pull request Jan 6, 2023

Bump helm chart version reference to 0.43.15 #21125

Closed

octavia-squidington-iii mentioned this pull request Jan 6, 2023

Bump Airbyte version from 0.40.26 to 0.40.27 #21130

Closed

sajarin added promoted difficulty - ⭐ reward-100 labels Jan 6, 2023

octavia-squidington-iii mentioned this pull request Jan 6, 2023

Bump Airbyte version from 0.40.26 to 0.40.27 #21135

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source AlphaVantage - add quote stream to alpha-vantage #20564

Source AlphaVantage - add quote stream to alpha-vantage #20564

sajarin commented Dec 16, 2022

sajarin commented Dec 16, 2022 •

edited by github-actions bot

Loading

geekwhocodes commented Dec 16, 2022 •

edited

Loading

geekwhocodes left a comment

sajarin commented Dec 16, 2022

geekwhocodes left a comment

marcosmarxm commented Dec 20, 2022

sajarin commented Jan 5, 2023 •

edited by github-actions bot

Loading

sajarin commented Jan 5, 2023 •

edited by github-actions bot

Loading

sajarin commented Jan 5, 2023 •

edited by github-actions bot

Loading

Source AlphaVantage - add quote stream to alpha-vantage #20564

Source AlphaVantage - add quote stream to alpha-vantage #20564

Conversation

sajarin commented Dec 16, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

sajarin commented Dec 16, 2022 • edited by github-actions bot Loading

Build Passed

geekwhocodes commented Dec 16, 2022 • edited Loading

geekwhocodes left a comment

Choose a reason for hiding this comment

sajarin commented Dec 16, 2022

geekwhocodes left a comment

Choose a reason for hiding this comment

marcosmarxm commented Dec 20, 2022

sajarin commented Jan 5, 2023 • edited by github-actions bot Loading

Build Passed

sajarin commented Jan 5, 2023 • edited by github-actions bot Loading

sajarin commented Jan 5, 2023 • edited by github-actions bot Loading

sajarin commented Dec 16, 2022 •

edited by github-actions bot

Loading

geekwhocodes commented Dec 16, 2022 •

edited

Loading

sajarin commented Jan 5, 2023 •

edited by github-actions bot

Loading

sajarin commented Jan 5, 2023 •

edited by github-actions bot

Loading

sajarin commented Jan 5, 2023 •

edited by github-actions bot

Loading