-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination Definitions: move normalization fields to normalizationConfig #20573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test this changes on cloud?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Note: don't forget to make the same changes to yamls in the cloud repo
This will happen automatically once this is merged - it'll trigger a regereration of the applied masks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
What
Fixes #20559
#20245 introduced a change to the StandardDestinationDefintion definition that moved the normalization fields into a
normalizationConfig
object within the definition. Some code was added to the ActorDefinitionsMigrator to handle this, but Cloud does not go through the ActorDefinitionsMigrator. This means that Cloud would not properly load the values of these normalization fields into the database, leading to null pointer exceptions.How