Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Definitions: move normalization fields to normalizationConfig #20573

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented Dec 16, 2022

What

Fixes #20559

#20245 introduced a change to the StandardDestinationDefintion definition that moved the normalization fields into a normalizationConfig object within the definition. Some code was added to the ActorDefinitionsMigrator to handle this, but Cloud does not go through the ActorDefinitionsMigrator. This means that Cloud would not properly load the values of these normalization fields into the database, leading to null pointer exceptions.

How

  • Update the destination definitions to the new format
  • Remove the code that handles this from the migrator

@pedroslopez pedroslopez temporarily deployed to more-secrets December 16, 2022 15:10 — with GitHub Actions Inactive
@pedroslopez pedroslopez temporarily deployed to more-secrets December 16, 2022 15:10 — with GitHub Actions Inactive
@pedroslopez pedroslopez temporarily deployed to more-secrets December 16, 2022 15:13 — with GitHub Actions Inactive
@pedroslopez pedroslopez temporarily deployed to more-secrets December 16, 2022 15:13 — with GitHub Actions Inactive
Copy link
Contributor

@andriikorotkov andriikorotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this changes on cloud?

@pedroslopez
Copy link
Contributor Author

pedroslopez commented Dec 16, 2022

Can we test this changes on cloud?

On it!

Edit: it works!

image

@pedroslopez pedroslopez marked this pull request as ready for review December 16, 2022 16:15
@pedroslopez pedroslopez changed the title move normalization fields to normalizationConfig Destination Definitions: move normalization fields to normalizationConfig Dec 16, 2022
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Note: don't forget to make the same changes to yamls in the cloud repo

@pedroslopez
Copy link
Contributor Author

Note: don't forget to make the same changes to yamls in the cloud repo

This will happen automatically once this is merged - it'll trigger a regereration of the applied masks

Copy link
Contributor

@git-phu git-phu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pedroslopez pedroslopez merged commit 12cc546 into master Dec 16, 2022
@pedroslopez pedroslopez deleted the pedroslopez/fix-definitions branch December 16, 2022 16:42
@sspaeti sspaeti mentioned this pull request Jan 10, 2023
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of NormalizationRunnerFactory introduced a bug - "this.normalizationIntegrationType" is null
4 participants