🪟 🔧 Update auto-detect schema feature name #20591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
josephkmh
approved these changes
Dec 16, 2022
edmundito
force-pushed
the
edmundito/update-auto-detect-schema-feature-name
branch
from
1eb24de
to
a8b8712
Compare
|
@tealjulia rebased and fixed the flag with in the SchemaChangesBackdrop |
teallarson
reviewed
Dec 16, 2022
| @@ -12,7 +12,7 @@ import { OctaviaYellowFlag } from "./OctaviaYellowFlag"; | |||
| import styles from "./SchemaChangeBackdrop.module.scss"; | |||
|
|
|||
| export const SchemaChangeBackdrop: React.FC<React.PropsWithChildren<unknown>> = ({ children }) => { | |||
| const allowAutoDetectSchemaChanges = useFeature(FeatureItem.AllowAutoDetectSchemaChanges); | |||
| const allowAutoDetectSchemaChanges = useFeature(FeatureItem.AllowAutoDetectSchema); | |||
There was a problem hiding this comment.
Suggested change
| const allowAutoDetectSchemaChanges = useFeature(FeatureItem.AllowAutoDetectSchema); | |
| const allowAutoDetectSchema = useFeature(FeatureItem.AllowAutoDetectSchema); |
to match the other spots we changed variable names
teallarson
approved these changes
Dec 16, 2022
edmundito
force-pushed
the
edmundito/update-auto-detect-schema-feature-name
branch
from
a8b8712
to
3b4e8d8
Compare
edmundito
deleted the
edmundito/update-auto-detect-schema-feature-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the name of the Auto-detect schema feature because it was not set up correctly in LaunchDarkly.
LaunchDarkly would not allow changing the type of the flag, so it needed to be archived and re-created with a new unique name.