-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🔧 Update auto-detect schema feature name #20591
🪟 🔧 Update auto-detect schema feature name #20591
Conversation
1eb24de
to
a8b8712
Compare
@tealjulia rebased and fixed the flag with in the SchemaChangesBackdrop |
@@ -12,7 +12,7 @@ import { OctaviaYellowFlag } from "./OctaviaYellowFlag"; | |||
import styles from "./SchemaChangeBackdrop.module.scss"; | |||
|
|||
export const SchemaChangeBackdrop: React.FC<React.PropsWithChildren<unknown>> = ({ children }) => { | |||
const allowAutoDetectSchemaChanges = useFeature(FeatureItem.AllowAutoDetectSchemaChanges); | |||
const allowAutoDetectSchemaChanges = useFeature(FeatureItem.AllowAutoDetectSchema); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const allowAutoDetectSchemaChanges = useFeature(FeatureItem.AllowAutoDetectSchema); | |
const allowAutoDetectSchema = useFeature(FeatureItem.AllowAutoDetectSchema); |
to match the other spots we changed variable names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test locally. Left one suggestion for variable name to match the others.
a8b8712
to
3b4e8d8
Compare
What
Updates the name of the Auto-detect schema feature because it was not set up correctly in LaunchDarkly.
LaunchDarkly would not allow changing the type of the flag, so it needed to be archived and re-created with a new unique name.