🪟 🐛 Fix non-breaking schema changes preference issues #20625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
commented
Dec 18, 2022
| @@ -153,6 +153,7 @@ | |||
| "connectionForm.nonBreakingChangesPreference.label": "Non-breaking schema updates detected*", | |||
| "connectionForm.nonBreakingChangesPreference.message": "Set how Airbyte handles syncs when it detects a non-breaking schema change in the source", | |||
| "connectionForm.nonBreakingChangesPreference.ignore": "Ignore", | |||
| "connectionForm.nonBreakingChangesPreference.disable": "Disable connection", | |||
There was a problem hiding this comment.
I made this "Disable connection" instead of "Pause sync" as shown in the design because we don't really have a concept of pausing in the UI and this is what will actually happen - @andyjih thoughts?
octavia-squidington-iv
added
area/platform
edmundito
commented
Dec 18, 2022
| @@ -11,12 +11,13 @@ import { useConnectionFormService } from "hooks/services/ConnectionForm/Connecti | |||
|
|
|||
| import styles from "./NonBreakingChangesPreferenceField.module.scss"; | |||
|
|
|||
| const SUPPORTED_PREFERENCES = [NonBreakingChangesPreference.ignore, NonBreakingChangesPreference.disable]; | |||
There was a problem hiding this comment.
We may add more options in the future that may not have an i18n string or may need to wait on the backend, so they need to be supported manually.
edmundito
commented
Dec 18, 2022
Comment on lines
-12
to
-16
| .connectorLabel { | ||
| max-width: 328px; | ||
| margin-right: variables.$spacing-xl; | ||
| vertical-align: top; | ||
| } |
There was a problem hiding this comment.
Probably copied from the Schedule field. That also needs to be cleaned up but I omitted it here because of the scope of the PR.
teallarson
approved these changes
Dec 18, 2022
edmundito
force-pushed
the
edmundito/fix-non-breaking-prefs
branch
from
6252665
to
129e378
Compare
This was referenced Jan 6, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes three issues: